Re: [PATCH 1/3] kbuild: Add -Wshadow to sparse

2018-10-17 Thread Sebastian Andrzej Siewior
On 2018-10-17 21:25:02 [+0200], Luc Van Oostenryck wrote: > Hi, Hi, > I made a quick test and I saw it would add a lot of noise because of > (valid) warnings coming from macros using a statement expression > redeclaring variables like '__u', 'tmp', ... > > BTW, as far as I can see, sparse never h

Re: [PATCH 1/3] kbuild: Add -Wshadow to sparse

2018-10-17 Thread Luc Van Oostenryck
On Wed, Oct 17, 2018 at 07:05:52PM +0200, Sebastian Andrzej Siewior wrote: > I remember that `sparse' used to warn about shadowed variables but it > seems not to do it by default anymore. It was useful. > > Enable `-Wshadow' while invoking sparse. Hi, I made a quick test and I saw it would add a

[PATCH 1/3] kbuild: Add -Wshadow to sparse

2018-10-17 Thread Sebastian Andrzej Siewior
I remember that `sparse' used to warn about shadowed variables but it seems not to do it by default anymore. It was useful. Enable `-Wshadow' while invoking sparse. Cc: linux-spa...@vger.kernel.org Cc: Masahiro Yamada Cc: Michal Marek Cc: linux-kbu...@vger.kernel.org Signed-off-by: Sebastian An