Re: [PATCH 1/3] i2c: update i2c_trace_msg static key to modern api

2018-03-26 Thread Peter Zijlstra
On Sun, Mar 25, 2018 at 12:10:54PM -0700, Davidlohr Bueso wrote: > @@ -1848,11 +1848,11 @@ int __i2c_transfer(struct i2c_adapter *adap, struct > i2c_msg *msgs, int num) > if (adap->quirks && i2c_check_for_quirks(adap, msgs, num)) > return -EOPNOTSUPP; > > - /* i2c_trace_m

Re: [PATCH 1/3] i2c: update i2c_trace_msg static key to modern api

2018-03-26 Thread Peter Zijlstra
On Sun, Mar 25, 2018 at 12:10:54PM -0700, Davidlohr Bueso wrote: > -static struct static_key i2c_trace_msg = STATIC_KEY_INIT_FALSE; > +DEFINE_STATIC_KEY_FALSE(i2c_trace_msg_key); static DEFINE_STATIC_KEY_FALSE()..

[PATCH 1/3] i2c: update i2c_trace_msg static key to modern api

2018-03-25 Thread Davidlohr Bueso
No changes in refcount semantics -- key init is false; replace static_key_slow_inc|dec with static_branch_inc|dec static_key_false with static_branch_unlikely Added a '_key' suffix to i2c_trace_msg, for better self documentation. Cc: Wolfram Sang Cc: linux-...@vger.kernel.org Sig