Re: [PATCH 1/3] cgroup: don't destroy the default root

On 2014/6/3 20:57, Tejun Heo wrote: > Hello, Li. > > On Tue, Jun 03, 2014 at 12:04:38PM +0800, Li Zefan wrote: >> static void cgroup_get(struct cgroup *cgrp) >> { >> WARN_ON_ONCE(cgroup_is_dead(cgrp)); >> -css_get(&cgrp->self); >> +if (!(cgrp->self.flags & CSS_NO_REF)) >> +

Re: [PATCH 1/3] cgroup: don't destroy the default root

Hello, Li. On Tue, Jun 03, 2014 at 12:04:38PM +0800, Li Zefan wrote: > static void cgroup_get(struct cgroup *cgrp) > { > WARN_ON_ONCE(cgroup_is_dead(cgrp)); > - css_get(&cgrp->self); > + if (!(cgrp->self.flags & CSS_NO_REF)) > + css_get(&cgrp->self); Hmmm? The same co

[PATCH 1/3] cgroup: don't destroy the default root

The default root is allocated and initialized at boot, so we shouldn't destroy the default root when it's umounted, otherwise it will lead to disaster. Signed-off-by: Li Zefan --- kernel/cgroup.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/kernel/cgroup.c b