Re: [PATCH 1/3] MIPS: c-r4k: instruction_hazard should immediately follow cache op

2017-12-21 Thread Matt Redfearn
Hi James, On 21/12/17 15:30, James Hogan wrote: On Thu, Dec 21, 2017 at 03:19:35PM +, Matt Redfearn wrote: Hi James, On 21/12/17 15:14, James Hogan wrote: On Thu, Dec 21, 2017 at 11:16:02AM +, Matt Redfearn wrote: During ftrace initialisation, placeholder instructions in the prologue

Re: [PATCH 1/3] MIPS: c-r4k: instruction_hazard should immediately follow cache op

2017-12-21 Thread James Hogan
On Thu, Dec 21, 2017 at 03:19:35PM +, Matt Redfearn wrote: > Hi James, > > On 21/12/17 15:14, James Hogan wrote: > > On Thu, Dec 21, 2017 at 11:16:02AM +, Matt Redfearn wrote: > >> During ftrace initialisation, placeholder instructions in the prologue > >> of every kernel function not mark

Re: [PATCH 1/3] MIPS: c-r4k: instruction_hazard should immediately follow cache op

2017-12-21 Thread Matt Redfearn
Hi James, On 21/12/17 15:14, James Hogan wrote: On Thu, Dec 21, 2017 at 11:16:02AM +, Matt Redfearn wrote: During ftrace initialisation, placeholder instructions in the prologue of every kernel function not marked "notrace" are replaced with nops. After the instructions are written (to the

Re: [PATCH 1/3] MIPS: c-r4k: instruction_hazard should immediately follow cache op

2017-12-21 Thread James Hogan
On Thu, Dec 21, 2017 at 11:16:02AM +, Matt Redfearn wrote: > During ftrace initialisation, placeholder instructions in the prologue > of every kernel function not marked "notrace" are replaced with nops. > After the instructions are written (to the dcache), flush_icache_range() > is used to ens

[PATCH 1/3] MIPS: c-r4k: instruction_hazard should immediately follow cache op

2017-12-21 Thread Matt Redfearn
During ftrace initialisation, placeholder instructions in the prologue of every kernel function not marked "notrace" are replaced with nops. After the instructions are written (to the dcache), flush_icache_range() is used to ensure that the icache will be updated with these replaced instructions. C