Re: [PATCH 1/3] KVM: Don't need to wakeup vCPU twice afer timer fire

2019-07-31 Thread Paolo Bonzini
On 31/07/19 15:14, Vitaly Kuznetsov wrote: > Paolo Bonzini writes: > >> On 31/07/19 13:27, Wanpeng Li wrote: >>> From: Wanpeng Li >>> >>> kvm_set_pending_timer() will take care to wake up the sleeping vCPU which >>> has pending timer, don't need to check this in apic_timer_expired() again. >> >

Re: [PATCH 1/3] KVM: Don't need to wakeup vCPU twice afer timer fire

2019-07-31 Thread Vitaly Kuznetsov
Paolo Bonzini writes: > On 31/07/19 13:27, Wanpeng Li wrote: >> From: Wanpeng Li >> >> kvm_set_pending_timer() will take care to wake up the sleeping vCPU which >> has pending timer, don't need to check this in apic_timer_expired() again. > > No, it doesn't. kvm_make_request never kicks the v

Re: [PATCH 1/3] KVM: Don't need to wakeup vCPU twice afer timer fire

2019-07-31 Thread Paolo Bonzini
On 31/07/19 13:27, Wanpeng Li wrote: > From: Wanpeng Li > > kvm_set_pending_timer() will take care to wake up the sleeping vCPU which > has pending timer, don't need to check this in apic_timer_expired() again. No, it doesn't. kvm_make_request never kicks the vCPU. Paolo > Cc: Paolo Bonzini

[PATCH 1/3] KVM: Don't need to wakeup vCPU twice afer timer fire

2019-07-31 Thread Wanpeng Li
From: Wanpeng Li kvm_set_pending_timer() will take care to wake up the sleeping vCPU which has pending timer, don't need to check this in apic_timer_expired() again. Cc: Paolo Bonzini Cc: Radim Krčmář Signed-off-by: Wanpeng Li --- arch/x86/kvm/lapic.c | 8 1 file changed, 8 deletio