Re: [PATCH 1/3] HWPOISON: fix action_result() to print out dirty/clean

2012-08-23 Thread Naoya Horiguchi
Hello, Thank you for your review. On Thu, Aug 23, 2012 at 05:33:30PM +0800, Fengguang Wu wrote: > On Wed, Aug 22, 2012 at 11:17:33AM -0400, Naoya Horiguchi wrote: > > action_result() fails to print out "dirty" even if an error occurred on a > > dirty pagecache, because when we check PageDirty in

Re: [PATCH 1/3] HWPOISON: fix action_result() to print out dirty/clean

2012-08-23 Thread Fengguang Wu
On Wed, Aug 22, 2012 at 11:17:33AM -0400, Naoya Horiguchi wrote: > action_result() fails to print out "dirty" even if an error occurred on a > dirty pagecache, because when we check PageDirty in action_result() it was > cleared after page isolation even if it's dirty before error handling. This > c

[PATCH 1/3] HWPOISON: fix action_result() to print out dirty/clean

2012-08-22 Thread Naoya Horiguchi
action_result() fails to print out "dirty" even if an error occurred on a dirty pagecache, because when we check PageDirty in action_result() it was cleared after page isolation even if it's dirty before error handling. This can break some applications that monitor this message, so should be fixed.

Re: [PATCH 1/3] HWPOISON: fix action_result() to print out dirty/clean

2012-08-10 Thread Andi Kleen
Naoya Horiguchi writes: > action_result() fails to print out "dirty" even if an error occurred on a > dirty pagecache, because when we check PageDirty in action_result() it was > cleared after page isolation even if it's dirty before error handling. This > can break some applications that monitor

[PATCH 1/3] HWPOISON: fix action_result() to print out dirty/clean

2012-08-10 Thread Naoya Horiguchi
action_result() fails to print out "dirty" even if an error occurred on a dirty pagecache, because when we check PageDirty in action_result() it was cleared after page isolation even if it's dirty before error handling. This can break some applications that monitor this message, so should be fixed.