RE: [PATCH 1/3] Fix ERROR: trailing statements should be on next line

2017-05-15 Thread David Laight
From: Alex Williamson > Sent: 15 May 2017 04:21 ... > > > /* Find end of list, sew whole thing into vi->rq.pages. */ > > > - for (end = page; end->private; end = (struct page *)end->private); > > > + for (end = page; end->private; end = (struct page *)end->private) > > > + ; > > FWIW, I

Re: [PATCH 1/3] Fix ERROR: trailing statements should be on next line

2017-05-14 Thread Alex Williamson
On Mon, 15 May 2017 05:58:05 +0300 "Michael S. Tsirkin" wrote: > On Sun, May 14, 2017 at 07:51:28PM +0200, Maciek Fijalkowski wrote: > > From: Maciej Fijalkowski > > > > Signed-off-by: Maciej Fijalkowski > > I prefer the original form - ; isn't a full statement. > > > --- > > drivers/net/

Re: [PATCH 1/3] Fix ERROR: trailing statements should be on next line

2017-05-14 Thread Michael S. Tsirkin
On Sun, May 14, 2017 at 07:51:28PM +0200, Maciek Fijalkowski wrote: > From: Maciej Fijalkowski > > Signed-off-by: Maciej Fijalkowski I prefer the original form - ; isn't a full statement. > --- > drivers/net/virtio_net.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --gi

[PATCH 1/3] Fix ERROR: trailing statements should be on next line

2017-05-14 Thread Maciek Fijalkowski
From: Maciej Fijalkowski Signed-off-by: Maciej Fijalkowski --- drivers/net/virtio_net.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 9320d96..f20dfb8 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio