Re: [PATCH 1/3] Adding Skyworks SKY81452 MFD driver

2014-08-27 Thread Gyungoh Yoo
On Wed, Aug 27, 2014 at 09:39:21AM +0100, Lee Jones wrote: > On Wed, 27 Aug 2014, Gyungoh Yoo wrote: > > On Tue, Aug 26, 2014 at 09:22:58AM +0100, Lee Jones wrote: > > > On Mon, 25 Aug 2014, Gyungoh Yoo wrote: > > > > On Thu, Aug 21, 2014 at 10:45:02AM +0100, Lee Jones wrote: > > > > > When you sen

Re: [PATCH 1/3] Adding Skyworks SKY81452 MFD driver

2014-08-27 Thread Lee Jones
On Wed, 27 Aug 2014, Gyungoh Yoo wrote: > On Tue, Aug 26, 2014 at 09:22:58AM +0100, Lee Jones wrote: > > On Mon, 25 Aug 2014, Gyungoh Yoo wrote: > > > On Thu, Aug 21, 2014 at 10:45:02AM +0100, Lee Jones wrote: > > > > When you send patch-sets, you should send them connected to one > > > > another A

Re: [PATCH 1/3] Adding Skyworks SKY81452 MFD driver

2014-08-26 Thread Gyungoh Yoo
On Tue, Aug 26, 2014 at 09:22:58AM +0100, Lee Jones wrote: > On Mon, 25 Aug 2014, Gyungoh Yoo wrote: > > On Thu, Aug 21, 2014 at 10:45:02AM +0100, Lee Jones wrote: > > > When you send patch-sets, you should send them connected to one > > > another AKA threaded. That way, when we're reviewing we ca

Re: [PATCH 1/3] Adding Skyworks SKY81452 MFD driver

2014-08-26 Thread Lee Jones
On Mon, 25 Aug 2014, Gyungoh Yoo wrote: > On Thu, Aug 21, 2014 at 10:45:02AM +0100, Lee Jones wrote: > > When you send patch-sets, you should send them connected to one > > another AKA threaded. That way, when we're reviewing we can look at > > the other patches in the set for reference. See the

Re: [PATCH 1/3] Adding Skyworks SKY81452 MFD driver

2014-08-25 Thread Gyungoh Yoo
Thank you for reviewing the patches. On Thu, Aug 21, 2014 at 10:45:02AM +0100, Lee Jones wrote: > When you send patch-sets, you should send them connected to one > another AKA threaded. That way, when we're reviewing we can look at > the other patches in the set for reference. See the man page f

Re: [PATCH 1/3] Adding Skyworks SKY81452 MFD driver

2014-08-21 Thread Lee Jones
On Thu, 21 Aug 2014, Thierry Reding wrote: > On Thu, Aug 21, 2014 at 10:45:02AM +0100, Lee Jones wrote: > [...] > > > diff --git a/drivers/mfd/sky81452.c b/drivers/mfd/sky81452.c > [...] > > > + * This program is free software; you can redistribute it and/or modify > > > it > > > + * under the te

Re: [PATCH 1/3] Adding Skyworks SKY81452 MFD driver

2014-08-21 Thread Thierry Reding
On Thu, Aug 21, 2014 at 10:45:02AM +0100, Lee Jones wrote: [...] > > diff --git a/drivers/mfd/sky81452.c b/drivers/mfd/sky81452.c [...] > > + * This program is free software; you can redistribute it and/or modify it > > + * under the terms of the GNU General Public License as published by the > > +

Re: [PATCH 1/3] Adding Skyworks SKY81452 MFD driver

2014-08-21 Thread Lee Jones
When you send patch-sets, you should send them connected to one another AKA threaded. That way, when we're reviewing we can look at the other patches in the set for reference. See the man page for `git send-email` for details. > Signed-off-by: Gyungoh Yoo > --- > Documentation/devicetree/bin

Re: [PATCH 1/3] Adding Skyworks SKY81452 MFD driver

2014-08-12 Thread Lee Jones
On Tue, 12 Aug 2014, GyungOh Yoo wrote: > Can somebody please review if the code has anything to improve? - Please don't top post - if you have a comment about the code, make your comment below the line(s) you are referring to and cut out all surplus quotes, replacing with "[...]". - This driver

Re: [PATCH 1/3] Adding Skyworks SKY81452 MFD driver

2014-08-11 Thread Gyungoh Yoo
Hello, Can somebody please review if the code has anything to improve? Thanks. On Fri, Aug 08, 2014 at 06:08:19PM +0900, Gyungoh Yoo wrote: > Signed-off-by: Gyungoh Yoo > --- > Documentation/devicetree/bindings/mfd/sky81452.txt | 24 + > .../devicetree/bindings/vendor-prefixes.txt

[PATCH 1/3] Adding Skyworks SKY81452 MFD driver

2014-08-08 Thread Gyungoh Yoo
Signed-off-by: Gyungoh Yoo --- Documentation/devicetree/bindings/mfd/sky81452.txt | 24 + .../devicetree/bindings/vendor-prefixes.txt| 1 + drivers/mfd/Kconfig| 12 +++ drivers/mfd/Makefile | 1 + drivers/mfd/sky81452