Re: [PATCH 1/3] ASoC:codec:max98373: Changed amp shutdown register as volatile

2021-03-25 Thread Mark Brown
On Wed, 24 Mar 2021 20:35:53 -0700, Ryan Lee wrote: > 0x20FF(amp global enable) register was defined as non-volatile, > but it is not. Overheating, overcurrent can cause amp shutdown > in hardware. > 'regmap_write' compare register readback value before writing > to avoid same value writing. 'regma

Re: [PATCH 1/3] ASoC:codec:max98373: Changed amp shutdown register as volatile

2021-03-25 Thread Mark Brown
On Wed, Mar 24, 2021 at 08:35:53PM -0700, Ryan Lee wrote: > 0x20FF(amp global enable) register was defined as non-volatile, > but it is not. Overheating, overcurrent can cause amp shutdown > in hardware. Please submit patches using subject lines reflecting the style for the subsystem, this makes i

[PATCH 1/3] ASoC:codec:max98373: Changed amp shutdown register as volatile

2021-03-24 Thread Ryan Lee
0x20FF(amp global enable) register was defined as non-volatile, but it is not. Overheating, overcurrent can cause amp shutdown in hardware. 'regmap_write' compare register readback value before writing to avoid same value writing. 'regmap_read' just read cache not actual hardware value for the non-