RE: [PATCH 1/3] ASoC: codecs: Add da7219 codec driver

2015-09-22 Thread Opensource [Adam Thomson]
On September 21, 2015 18:11, Mark Brown wrote: > > In a system scenario the likelihood of that happening is small as you > > cannot use the mic or headphones until they've been inserted. The system is > > only likely to act after the jack insertion events have occurred. However, > > it > > This

Re: [PATCH 1/3] ASoC: codecs: Add da7219 codec driver

2015-09-21 Thread Mark Brown
On Mon, Sep 21, 2015 at 03:08:03PM +, Opensource [Adam Thomson] wrote: > On September 19, 2015 18:44, Mark Brown wrote: > > This is obviously a massive reconfiguration of the device. I'm not > > seeing anything here which prevents userspace coming in and change the > > configuration while we'

RE: [PATCH 1/3] ASoC: codecs: Add da7219 codec driver

2015-09-21 Thread Opensource [Adam Thomson]
On September 19, 2015 18:44, Mark Brown wrote: > > + do { > > + statusa = snd_soc_read(codec, DA7219_ACCDET_STATUS_A); > > + if (statusa & DA7219_MICBIAS_UP_STS_MASK) > > + micbias_up = true; > > + } while (!micbias_up); > > This could go into an inifinit

Re: [PATCH 1/3] ASoC: codecs: Add da7219 codec driver

2015-09-19 Thread Mark Brown
On Thu, Sep 17, 2015 at 05:01:14PM +0100, Adam Thomson wrote: > + do { > + statusa = snd_soc_read(codec, DA7219_ACCDET_STATUS_A); > + if (statusa & DA7219_MICBIAS_UP_STS_MASK) > + micbias_up = true; > + } while (!micbias_up); This could go into

[PATCH 1/3] ASoC: codecs: Add da7219 codec driver

2015-09-17 Thread Adam Thomson
This adds support for the DA7219 audio codec with built-in advanced accessory detect features. Signed-off-by: Adam Thomson --- include/sound/da7219-aad.h| 99 +++ include/sound/da7219.h| 76 ++ sound/soc/codecs/Kconfig |4 + sound/soc/codecs/Makefile |2 + sound/