Re: [PATCH 1/3] [POWERPC] 8xx: mpc885ads pcmcia support

2007-05-14 Thread Andrew Morton
On Wed, 09 May 2007 02:31:25 +0400 Vitaly Bordug <[EMAIL PROTECTED]> wrote: > +/* > + * Some internal interrupt registers use an 8-bit mask for the interrupt > + * level instead of a number. > + */ > +static inline uint mk_int_int_mask(uint mask) { > + return (1 << (7 - (mask/2))); > +} grum

[PATCH 1/3] [POWERPC] 8xx: mpc885ads pcmcia support

2007-05-08 Thread Vitaly Bordug
Adds support for PowerQuicc on-chip PCMCIA. The driver is implemented as of_device, so only arch/powerpc stuff is capable to use it, which now implies only mpc885ads reference board. To cope with the code that should be hooked inside driver, but is really board specific (like set_voltage), global

Re: [PATCH 1/3] [POWERPC] 8xx: mpc885ads pcmcia support

2007-05-08 Thread Vitaly Bordug
On Tue, 8 May 2007 09:04:22 -0500 Kumar Gala wrote: > > + device_type = "pcmcia"; > > + reg = <80 80>; > > + clock-frequency = <2faf080>; > > is the clock-freq fixed? As I see now, that field is not really required as never extracted or used

Re: [PATCH 1/3] [POWERPC] 8xx: mpc885ads pcmcia support

2007-05-08 Thread Vitaly Bordug
On Tue, 8 May 2007 09:04:22 -0500 Kumar Gala wrote: > > On May 8, 2007, at 4:50 AM, Vitaly Bordug wrote: > > > > > Adds support for PowerQuicc on-chip PCMCIA. The driver is > > implemented as > > of_device, so only arch/powerpc stuff is capable to use it, which > > now implies only mpc885ads r

Re: [PATCH 1/3] [POWERPC] 8xx: mpc885ads pcmcia support

2007-05-08 Thread Kumar Gala
On May 8, 2007, at 4:50 AM, Vitaly Bordug wrote: Adds support for PowerQuicc on-chip PCMCIA. The driver is implemented as of_device, so only arch/powerpc stuff is capable to use it, which now implies only mpc885ads reference board. To cope with the code that should be hooked inside driver,

[PATCH 1/3] [POWERPC] 8xx: mpc885ads pcmcia support

2007-05-08 Thread Vitaly Bordug
Adds support for PowerQuicc on-chip PCMCIA. The driver is implemented as of_device, so only arch/powerpc stuff is capable to use it, which now implies only mpc885ads reference board. To cope with the code that should be hooked inside driver, but is really board specific (like set_voltage), global

Re: [PATCH 1/3] [POWERPC] 8xx: mpc885ads pcmcia support

2007-05-07 Thread Olof Johansson
On Tue, May 08, 2007 at 09:48:44AM +0400, Vitaly Bordug wrote: > > Adds support for PowerQuicc on-chip PCMCIA. The driver is implemented as > of_device, so only arch/powerpc stuff is capable to use it, which now > implies only mpc885ads reference board. > > To cope with the code that should be ho

Re: [PATCH 1/3] [POWERPC] 8xx: mpc885ads pcmcia support

2007-05-07 Thread Olof Johansson
On Tue, May 08, 2007 at 04:36:51AM +0400, Vitaly Bordug wrote: > > Adds support for PowerQuicc on-chip PCMCIA. The driver is implemented as > of_device, so only arch/powerpc stuff is capable to use it, which now > implies only mpc885ads reference board. > > To cope with the code that should be ho

[PATCH 1/3] [POWERPC] 8xx: mpc885ads pcmcia support

2007-05-07 Thread Vitaly Bordug
Adds support for PowerQuicc on-chip PCMCIA. The driver is implemented as of_device, so only arch/powerpc stuff is capable to use it, which now implies only mpc885ads reference board. To cope with the code that should be hooked inside driver, but is really board specific (like set_voltage), global