RE: [PATCH 1/2 v2] SPI: spi-pxa2xx: Add helpers for regiseters' accessing

2014-10-07 Thread Chen, Alvin
> I'm okay with the current version, though I have few minor comments below. > > > Introduce helper functions to access the 'SSCR0' and 'SSCR1'. > > > > Like you said in the summary there are many accessors to many registers, not > only cr1/cr0. Perhaps, you may extend your commit message. > OK

Re: [PATCH 1/2 v2] SPI: spi-pxa2xx: Add helpers for regiseters' accessing

2014-09-29 Thread Mika Westerberg
On Mon, Sep 29, 2014 at 07:22:27AM -0700, Weike Chen wrote: > Introduce helper functions to access the 'SSCR0' and 'SSCR1'. > > Signed-off-by: Weike Chen Please fix the minor issues Andy pointed out and then you can have my, Acked-by: Mika Westerberg -- To unsubscribe from this list: send the

Re: [PATCH 1/2 v2] SPI: spi-pxa2xx: Add helpers for regiseters' accessing

2014-09-29 Thread Andy Shevchenko
On Mon, 2014-09-29 at 07:22 -0700, Weike Chen wrote: I'm okay with the current version, though I have few minor comments below. > Introduce helper functions to access the 'SSCR0' and 'SSCR1'. > Like you said in the summary there are many accessors to many registers, not only cr1/cr0. Perhaps,

[PATCH 1/2 v2] SPI: spi-pxa2xx: Add helpers for regiseters' accessing

2014-09-28 Thread Weike Chen
Introduce helper functions to access the 'SSCR0' and 'SSCR1'. Signed-off-by: Weike Chen --- drivers/spi/spi-pxa2xx.c | 108 -- 1 file changed, 85 insertions(+), 23 deletions(-) diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c index 25