Re: [PATCH 1/2] zsmalloc: do not remap dst page while prepare next src page

2015-03-24 Thread Sergey Senozhatsky
On (03/25/15 14:05), Heesub Shin wrote: > No, it's not unnecessary. We should do kunmap_atomic() in the reverse > order of kmap_atomic(), so unfortunately it's inevitable to > kunmap_atomic() both on d_addr and s_addr. > Andrew, can you please drop this patch? > > > > Signed-off-by: Sergey Sen

Re: [PATCH 1/2] zsmalloc: do not remap dst page while prepare next src page

2015-03-24 Thread Heesub Shin
Hello, On 03/25/2015 12:24 AM, Sergey Senozhatsky wrote: > object may belong to different pages. zs_object_copy() handles > this case and maps a new source page (get_next_page() and > kmap_atomic()) when object crosses boundaries of the current > source page. But it also performs unnecessary kunma

[PATCH 1/2] zsmalloc: do not remap dst page while prepare next src page

2015-03-24 Thread Sergey Senozhatsky
object may belong to different pages. zs_object_copy() handles this case and maps a new source page (get_next_page() and kmap_atomic()) when object crosses boundaries of the current source page. But it also performs unnecessary kunmap/kmap_atomic of the destination page (it remains unchanged), whic