Re: [PATCH 1/2] x86: change names of e820 memory map type

2013-03-01 Thread H. Peter Anvin
Irrelevant. li guang wrote: >gratuitous? > >It was inspired by gtk library's key definitions, >gtk original keys like GDK_1, GDK_2, GDK_p, GDK_q, GDK_tab ... >now they all be changed to GDK_KEY_1, GDK_KEY_2 ... >do you think it's reasonable? >or gratuitous? > > >在 2013-02-28四的 21:29 -0800，H. Pet

Re: [PATCH 1/2] x86: change names of e820 memory map type

2013-03-01 Thread Ingo Molnar
* li guang wrote: > gratuitous? > > It was inspired by gtk library's key definitions, I don't think GTK is a shining example of API cleanliness and usability that the kernel should strive to imitate, especially not in the naming department... > gtk original keys like GDK_1, GDK_2, GDK_p, GD

Re: [PATCH 1/2] x86: change names of e820 memory map type

2013-03-01 Thread li guang
gratuitous? It was inspired by gtk library's key definitions, gtk original keys like GDK_1, GDK_2, GDK_p, GDK_q, GDK_tab ... now they all be changed to GDK_KEY_1, GDK_KEY_2 ... do you think it's reasonable? or gratuitous? 在 2013-02-28四的 21:29 -0800，H. Peter Anvin写道： > NAK. Gratuitous pointless

Re: [PATCH 1/2] x86: change names of e820 memory map type

2013-02-28 Thread H. Peter Anvin
NAK. Gratuitous pointless change. liguang wrote: >E820_RAM -> E820_TYPE_RAM >E820_ACPI-> E820_TYPE_ACPI >... > >names like E820_RAM is conflict-prone, >because user is more likely to define >a macro like this if did not strongly >aware this name have been defined >by e820.h > >Signed-off-by: li

[PATCH 1/2] x86: change names of e820 memory map type

2013-02-28 Thread liguang
E820_RAM -> E820_TYPE_RAM E820_ACPI-> E820_TYPE_ACPI ... names like E820_RAM is conflict-prone, because user is more likely to define a macro like this if did not strongly aware this name have been defined by e820.h Signed-off-by: liguang --- arch/x86/boot/compressed/eboot.c | 10 +++---