Re: [PATCH 1/2] vfio/pci: Remove redundant declaration of vfio_pci_driver

2020-09-18 Thread Zenghui Yu
On 2020/9/18 6:22, Alex Williamson wrote: On Thu, 17 Sep 2020 11:31:27 +0800 Zenghui Yu wrote: It was added by commit 137e5531351d ("vfio/pci: Add sriov_configure support") and actually unnecessary. Remove it. Looks correct, but I might clarify as: s/unnecessary/duplicates a forward declara

Re: [PATCH 1/2] vfio/pci: Remove redundant declaration of vfio_pci_driver

2020-09-17 Thread Alex Williamson
On Thu, 17 Sep 2020 11:31:27 +0800 Zenghui Yu wrote: > It was added by commit 137e5531351d ("vfio/pci: Add sriov_configure > support") and actually unnecessary. Remove it. Looks correct, but I might clarify as: s/unnecessary/duplicates a forward declaration earlier in the file/ I can change on

Re: [PATCH 1/2] vfio/pci: Remove redundant declaration of vfio_pci_driver

2020-09-17 Thread Cornelia Huck
On Thu, 17 Sep 2020 11:31:27 +0800 Zenghui Yu wrote: > It was added by commit 137e5531351d ("vfio/pci: Add sriov_configure > support") and actually unnecessary. Remove it. > > Signed-off-by: Zenghui Yu > --- > drivers/vfio/pci/vfio_pci.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a

[PATCH 1/2] vfio/pci: Remove redundant declaration of vfio_pci_driver

2020-09-16 Thread Zenghui Yu
It was added by commit 137e5531351d ("vfio/pci: Add sriov_configure support") and actually unnecessary. Remove it. Signed-off-by: Zenghui Yu --- drivers/vfio/pci/vfio_pci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c index 1ab1f5cd