Re: [PATCH 1/2] vdso: allow to add architecture-specific vdso data

2020-08-03 Thread Sven Schnelle
Thomas Gleixner writes: > just a few nits. > > Can you please spare that #ifdef and do: > > #ifdef CONFIG_ARCH_HAS_VDSO_DATA > #include > #else > struct arch_vdso_data {}; > #endif Ok. > Please keep the tabular alignment of the struct members and add kernel > doc in the comment above the struc

Re: [PATCH 1/2] vdso: allow to add architecture-specific vdso data

2020-08-03 Thread Thomas Gleixner
Sven, Sven Schnelle writes: > source "scripts/gcc-plugins/Kconfig" > diff --git a/include/vdso/datapage.h b/include/vdso/datapage.h > index 7955c56d6b3c..74e730238ce6 100644 > --- a/include/vdso/datapage.h > +++ b/include/vdso/datapage.h > @@ -19,6 +19,10 @@ > #include > #include > > +#ifd

[PATCH 1/2] vdso: allow to add architecture-specific vdso data

2020-08-02 Thread Sven Schnelle
Add the possibility to add architecture specific vDSO data to struct vdso_data. This is useful if the arch specific user space VDSO code needs additional data during execution. If CONFIG_ARCH_HAS_VDSO_DATA is defined, the generic code will include asm/vdso/data.h which should contain 'struct arch_v