Re: [PATCH 1/2] time: settimeofday: Validate the values of tv from user

2015-01-07 Thread Greg KH
On Wed, Jan 07, 2015 at 11:02:01AM -0800, John Stultz wrote: > On Wed, Jan 7, 2015 at 10:28 AM, Greg KH wrote: > > On Wed, Jan 07, 2015 at 10:12:19AM -0800, John Stultz wrote: > >> From: Sasha Levin > >> > >> An unvalidated user input is multiplied by a constant, which can result in > >> an undef

Re: [PATCH 1/2] time: settimeofday: Validate the values of tv from user

2015-01-07 Thread Sasha Levin
On 01/07/2015 02:02 PM, John Stultz wrote: > On Wed, Jan 7, 2015 at 10:28 AM, Greg KH wrote: >> On Wed, Jan 07, 2015 at 10:12:19AM -0800, John Stultz wrote: >>> From: Sasha Levin >>> >>> An unvalidated user input is multiplied by a constant, which can result in >>> an undefined behaviour for larg

Re: [PATCH 1/2] time: settimeofday: Validate the values of tv from user

2015-01-07 Thread John Stultz
On Wed, Jan 7, 2015 at 10:28 AM, Greg KH wrote: > On Wed, Jan 07, 2015 at 10:12:19AM -0800, John Stultz wrote: >> From: Sasha Levin >> >> An unvalidated user input is multiplied by a constant, which can result in >> an undefined behaviour for large values. While this is validated later, >> we sho

Re: [PATCH 1/2] time: settimeofday: Validate the values of tv from user

2015-01-07 Thread Greg KH
On Wed, Jan 07, 2015 at 10:12:19AM -0800, John Stultz wrote: > From: Sasha Levin > > An unvalidated user input is multiplied by a constant, which can result in > an undefined behaviour for large values. While this is validated later, > we should avoid triggering undefined behaviour. > > Cc: Thom

[PATCH 1/2] time: settimeofday: Validate the values of tv from user

2015-01-07 Thread John Stultz
From: Sasha Levin An unvalidated user input is multiplied by a constant, which can result in an undefined behaviour for large values. While this is validated later, we should avoid triggering undefined behaviour. Cc: Thomas Gleixner Cc: Ingo Molnar Cc: stable Cc: Andy Lutomirski Signed-off-b

Re: [PATCH 1/2] time: settimeofday: Validate the values of tv from user

2015-01-02 Thread Andy Lutomirski
On 01/02/2015 11:51 AM, John Stultz wrote: > From: Sasha Levin > > An unvalidated user input is multiplied by a constant, which can result in > an undefined behaviour for large values. While this is validated later, > we should avoid triggering undefined behaviour. > > Cc: Thomas Gleixner > Cc:

[PATCH 1/2] time: settimeofday: Validate the values of tv from user

2015-01-02 Thread John Stultz
From: Sasha Levin An unvalidated user input is multiplied by a constant, which can result in an undefined behaviour for large values. While this is validated later, we should avoid triggering undefined behaviour. Cc: Thomas Gleixner Cc: Ingo Molnar Cc: stable Signed-off-by: Sasha Levin Signe