Re: [PATCH 1/2] sysctl: Properly register the irda binary sysctl numbers.

2007-08-28 Thread Eric W. Biederman
[EMAIL PROTECTED] writes: > On Sat, 25 Aug 2007 11:59:53 MDT, Eric W. Biederman said: > >> It looks like you don't have CONFIG_SYSCTL_SYSCALL defined, and it >> appears utsname_syscall and ipcdata_syscall both become NULL pointers >> if they aren't needed. So the complaint is a false positive. >

Re: [PATCH 1/2] sysctl: Properly register the irda binary sysctl numbers.

2007-08-28 Thread Valdis . Kletnieks
On Sat, 25 Aug 2007 11:59:53 MDT, Eric W. Biederman said: > It looks like you don't have CONFIG_SYSCTL_SYSCALL defined, and it > appears utsname_syscall and ipcdata_syscall both become NULL pointers > if they aren't needed. So the complaint is a false positive. Yep. Nothing I actually use needs

Re: [PATCH 1/2] sysctl: Properly register the irda binary sysctl numbers.

2007-08-26 Thread Samuel Ortiz
Hi Eric, On Thu, Aug 23, 2007 at 09:53:53PM -0600, Eric W. Biederman wrote: > > Grumble. These numbers should have been in sysctl.h from the > beginning if we ever expected anyone to use them. Oh well put > them there now so we can find them and make maintenance easier. Thanks for that, I shoul

Re: [PATCH 1/2] sysctl: Properly register the irda binary sysctl numbers.

2007-08-25 Thread Eric W. Biederman
[EMAIL PROTECTED] writes: > On Sat, 25 Aug 2007 06:57:17 MDT, Eric W. Biederman said: > >> It's good to have confirmation that my sysctl_check routine >> didn't find something else wrong. > > If I understand the code, anything it whinges about is either an outright bug > or it's a round of ammo al

Re: [PATCH 1/2] sysctl: Properly register the irda binary sysctl numbers.

2007-08-25 Thread Valdis . Kletnieks
On Sat, 25 Aug 2007 06:57:17 MDT, Eric W. Biederman said: > It's good to have confirmation that my sysctl_check routine > didn't find something else wrong. If I understand the code, anything it whinges about is either an outright bug or it's a round of ammo already chambered. ;) As far as "somet

Re: [PATCH 1/2] sysctl: Properly register the irda binary sysctl numbers.

2007-08-25 Thread Eric W. Biederman
[EMAIL PROTECTED] writes: > On Thu, 23 Aug 2007 21:53:53 MDT, Eric W. Biederman said: >> >> Grumble. These numbers should have been in sysctl.h from the >> beginning if we ever expected anyone to use them. Oh well put >> them there now so we can find them and make maintenance easier. >> >> Sig

Re: [PATCH 1/2] sysctl: Properly register the irda binary sysctl numbers.

2007-08-25 Thread Valdis . Kletnieks
On Thu, 23 Aug 2007 21:53:53 MDT, Eric W. Biederman said: > > Grumble. These numbers should have been in sysctl.h from the > beginning if we ever expected anyone to use them. Oh well put > them there now so we can find them and make maintenance easier. > > Signed-off-by: Eric W. Biederman <[EMA

[PATCH 1/2] sysctl: Properly register the irda binary sysctl numbers.

2007-08-23 Thread Eric W. Biederman
Grumble. These numbers should have been in sysctl.h from the beginning if we ever expected anyone to use them. Oh well put them there now so we can find them and make maintenance easier. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- include/linux/sysctl.h | 20