Re: [PATCH 1/2] soc: qcom: Add TCSR driver

2015-01-09 Thread Bjorn Andersson
On Fri, Jan 9, 2015 at 9:13 AM, Andy Gross wrote: > On Fri, Jan 09, 2015 at 01:06:56AM +0100, Arnd Bergmann wrote: >> On Thursday 08 January 2015 16:52:56 Andy Gross wrote: >> > This patch adds support for the TCSR (Top Control and Status Register) IP >> > block >> > that is present in the Qualco

Re: [PATCH 1/2] soc: qcom: Add TCSR driver

2015-01-09 Thread Andy Gross
On Fri, Jan 09, 2015 at 01:06:56AM +0100, Arnd Bergmann wrote: > On Thursday 08 January 2015 16:52:56 Andy Gross wrote: > > This patch adds support for the TCSR (Top Control and Status Register) IP > > block > > that is present in the Qualcomm IPQ8064, APQ8064, and some later processors. > > This

Re: [PATCH 1/2] soc: qcom: Add TCSR driver

2015-01-09 Thread Andy Gross
On Thu, Jan 08, 2015 at 03:39:44PM -0800, Stephen Boyd wrote: > On 01/08/2015 02:52 PM, Andy Gross wrote: > > + > > +static struct platform_driver qcom_tcsr_driver = { > > + .driver = { > > + .name = "tcsr", > > + .owner = THIS_MODULE, > > This is done by t

Re: [PATCH 1/2] soc: qcom: Add TCSR driver

2015-01-08 Thread Arnd Bergmann
On Thursday 08 January 2015 16:52:56 Andy Gross wrote: > This patch adds support for the TCSR (Top Control and Status Register) IP > block > that is present in the Qualcomm IPQ8064, APQ8064, and some later processors. > This block contains additional configuration and mux settings for various > pe

Re: [PATCH 1/2] soc: qcom: Add TCSR driver

2015-01-08 Thread Stephen Boyd
On 01/08/2015 02:52 PM, Andy Gross wrote: > + > +static struct platform_driver qcom_tcsr_driver = { > + .driver = { > + .name = "tcsr", > + .owner = THIS_MODULE, This is done by the module_platform_driver() macro now so it's largely unnecessary. Best

[PATCH 1/2] soc: qcom: Add TCSR driver

2015-01-08 Thread Andy Gross
This patch adds support for the TCSR (Top Control and Status Register) IP block that is present in the Qualcomm IPQ8064, APQ8064, and some later processors. This block contains additional configuration and mux settings for various peripherals in the system, including the ADM DMA block and USB contr