Re: [PATCH 1/2] serial: 8250-mtk: add follow control

2019-04-28 Thread Sean Wang
Hi, Long I guess you should mean "flow control", not "follow control". And the commit subject should be swapped between 1/2 and 2/2, otherwise, the subject is inconsistent with its own content. Sean On Thu, Apr 25, 2019 at 1:41 AM Long Cheng wrote: > > Add SW and HW follow control functi

Re: [PATCH 1/2] serial: 8250-mtk: add follow control

2019-04-25 Thread Long Cheng
On Thu, 2019-04-25 at 12:40 +0200, Matthias Brugger wrote: > > On 25/04/2019 10:41, Long Cheng wrote: > > Add SW and HW follow control function. > > Can you please explain a bit more what you are doing in this patch. > You change the setting of the registers for different baud rates. Please > ela

Re: [PATCH 1/2] serial: 8250-mtk: add follow control

2019-04-25 Thread Matthias Brugger
On 25/04/2019 10:41, Long Cheng wrote: > Add SW and HW follow control function. Can you please explain a bit more what you are doing in this patch. You change the setting of the registers for different baud rates. Please elaborate what is happening there. > > Signed-off-by: Long Cheng > ---

[PATCH 1/2] serial: 8250-mtk: add follow control

2019-04-25 Thread Long Cheng
Add SW and HW follow control function. Signed-off-by: Long Cheng --- drivers/tty/serial/8250/8250_mtk.c | 60 ++-- 1 file changed, 37 insertions(+), 23 deletions(-) diff --git a/drivers/tty/serial/8250/8250_mtk.c b/drivers/tty/serial/8250/8250_mtk.c index c1fd