Re: [PATCH 1/2] remoteproc: Add remote processor coredump support

2017-07-12 Thread Bjorn Andersson
On Wed 21 Jun 13:54 PDT 2017, Suman Anna wrote: [..] > >>> diff --git a/drivers/remoteproc/qcom_common.c > >>> b/drivers/remoteproc/qcom_common.c [..] > >>> +int qcom_register_dump_segments(struct rproc *rproc, > >>> +const struct firmware *fw) > >>> +{ > >>> +struct rproc_dump_

Re: [PATCH 1/2] remoteproc: Add remote processor coredump support

2017-07-12 Thread Bjorn Andersson
On Thu 15 Jun 11:48 PDT 2017, Suman Anna wrote: [..] > > +static int rproc_coredump_add_header(struct rproc *rproc) > > +{ > > + struct rproc_dump_segment *entry; > > + struct elf32_phdr *phdr; > > + struct elf32_hdr *ehdr; > > + int nsegments = 0; > > + size_t offset; > > + > > + list_

Re: [PATCH 1/2] remoteproc: Add remote processor coredump support

2017-07-12 Thread Bjorn Andersson
On Wed 14 Jun 11:06 PDT 2017, Sarangdhar Joshi wrote: > The remoteproc framework shuts down and immediately restarts the > remote processor after fatal events (such as when remote crashes) > during the recovery path. This makes it lose the state of the > remote firmware at the point of failure, ma

Re: [PATCH 1/2] remoteproc: Add remote processor coredump support

2017-07-06 Thread Sarangdhar Joshi
On 6/21/2017 1:54 PM, Suman Anna wrote: Hi Sarang, Hi Sumant, Thanks for reviewing the patch.> >> On 06/14/2017 01:06 PM, Sarangdhar Joshi wrote: The remoteproc framework shuts down and immediately restarts the remote processor after fatal events (such as when remote crashes) during the r

Re: [PATCH 1/2] remoteproc: Add remote processor coredump support

2017-06-21 Thread Suman Anna
Hi Sarang, > Thanks for reviewing the patch.> >> >> On 06/14/2017 01:06 PM, Sarangdhar Joshi wrote: >>> The remoteproc framework shuts down and immediately restarts the >>> remote processor after fatal events (such as when remote crashes) >>> during the recovery path. >> >> This is the case in pr

Re: [PATCH 1/2] remoteproc: Add remote processor coredump support

2017-06-15 Thread Sarangdhar Joshi
On 6/15/2017 11:48 AM, Suman Anna wrote: Hi Sarangdhar, Hi Suman, Thanks for reviewing the patch. On 06/14/2017 01:06 PM, Sarangdhar Joshi wrote: The remoteproc framework shuts down and immediately restarts the remote processor after fatal events (such as when remote crashes) during the re

Re: [PATCH 1/2] remoteproc: Add remote processor coredump support

2017-06-15 Thread Suman Anna
Hi Sarangdhar, On 06/14/2017 01:06 PM, Sarangdhar Joshi wrote: The remoteproc framework shuts down and immediately restarts the remote processor after fatal events (such as when remote crashes) during the recovery path. This is the case in production systems, but your statement is not entire

[PATCH 1/2] remoteproc: Add remote processor coredump support

2017-06-14 Thread Sarangdhar Joshi
The remoteproc framework shuts down and immediately restarts the remote processor after fatal events (such as when remote crashes) during the recovery path. This makes it lose the state of the remote firmware at the point of failure, making it harder to debug such events. This patch introduces a m