Re: [PATCH 1/2] regulator: qcom-labibb: avoid unbalanced IRQ enable

2021-02-02 Thread Matti Vaittinen
Hello Angelo, On Tue, 2021-02-02 at 15:42 +0100, AngeloGioacchino Del Regno wrote: > Il 02/02/21 08:36, Matti Vaittinen ha scritto: > > If a spurious OCP IRQ occurs the isr schedules delayed work > > but does not disable the IRQ. The delayed work assumes IRQ was > > disabled in handler and attempt

Re: (subset) [PATCH 1/2] regulator: qcom-labibb: avoid unbalanced IRQ enable

2021-02-02 Thread Mark Brown
On Tue, 2 Feb 2021 09:36:34 +0200, Matti Vaittinen wrote: > If a spurious OCP IRQ occurs the isr schedules delayed work > but does not disable the IRQ. The delayed work assumes IRQ was > disabled in handler and attempts enabling it again causing > unbalanced enable. > > Fixes: 390af53e04114 ("regu

Re: [PATCH 1/2] regulator: qcom-labibb: avoid unbalanced IRQ enable

2021-02-02 Thread AngeloGioacchino Del Regno
Il 02/02/21 08:36, Matti Vaittinen ha scritto: If a spurious OCP IRQ occurs the isr schedules delayed work but does not disable the IRQ. The delayed work assumes IRQ was disabled in handler and attempts enabling it again causing unbalanced enable. You break the logic like this. Though, I also

[PATCH 1/2] regulator: qcom-labibb: avoid unbalanced IRQ enable

2021-02-01 Thread Matti Vaittinen
If a spurious OCP IRQ occurs the isr schedules delayed work but does not disable the IRQ. The delayed work assumes IRQ was disabled in handler and attempts enabling it again causing unbalanced enable. Fixes: 390af53e04114 ("regulator: qcom-labibb: Implement short-circuit and over-current IRQs")