Re: [PATCH 1/2] regmap: irq: add support for configuration of trigger type

2016-01-05 Thread Laxman Dewangan
On Tuesday 05 January 2016 11:11 PM, Mark Brown wrote: * PGP Signed by an unknown key On Tue, Dec 22, 2015 at 06:25:26PM +0530, Laxman Dewangan wrote: + d->type_reg_stride = chip->type_reg_stride ? : 1; + Please don't abuse the ternery operator, especially not the GCC extension - that'

Re: [PATCH 1/2] regmap: irq: add support for configuration of trigger type

2016-01-05 Thread Mark Brown
On Tue, Dec 22, 2015 at 06:25:26PM +0530, Laxman Dewangan wrote: > + d->type_reg_stride = chip->type_reg_stride ? : 1; > + Please don't abuse the ternery operator, especially not the GCC extension - that's much less clear than just writing the if statement. signature.asc Description: PGP si

[PATCH 1/2] regmap: irq: add support for configuration of trigger type

2015-12-22 Thread Laxman Dewangan
Some of devices supports the trigger level for interrupt like rising/falling edge specially for GPIOs. The interrupt support of such devices may have uses the generic regmap irq framework for implementation. Add support to configure the trigger type device interrupt register via regmap-irq framewo