Re: [PATCH 1/2] platform/chrome: cros_ec_spi: Don't overwrite spi::mode

2020-12-04 Thread Enric Balletbo i Serra
Hi Stephen, Thank you for your patch. On 3/12/20 2:16, Stephen Boyd wrote: > There isn't any need to overwrite the mode here in the driver with what > has been detected by the firmware, such as DT or ACPI. In fact, if we > use the SPI CS gpio descriptor feature we will overwrite the mode with > S

Re: [PATCH 1/2] platform/chrome: cros_ec_spi: Don't overwrite spi::mode

2020-12-02 Thread Doug Anderson
Hi, On Wed, Dec 2, 2020 at 5:16 PM Stephen Boyd wrote: > > There isn't any need to overwrite the mode here in the driver with what > has been detected by the firmware, such as DT or ACPI. In fact, if we > use the SPI CS gpio descriptor feature we will overwrite the mode with > SPI_MODE_0 where it

[PATCH 1/2] platform/chrome: cros_ec_spi: Don't overwrite spi::mode

2020-12-02 Thread Stephen Boyd
There isn't any need to overwrite the mode here in the driver with what has been detected by the firmware, such as DT or ACPI. In fact, if we use the SPI CS gpio descriptor feature we will overwrite the mode with SPI_MODE_0 where it already contains SPI_MODE_0 and more importantly SPI_CS_HIGH. Clea