Re: [PATCH 1/2] pinctrl: pxa3xx: Use devm_request_and_ioremap

2012-11-15 Thread Haojian Zhuang
On Thu, Nov 15, 2012 at 7:19 PM, Linus Walleij wrote: > On Wed, Nov 14, 2012 at 2:47 AM, Haojian Zhuang > wrote: >> On Tue, Nov 13, 2012 at 10:33 PM, Linus Walleij >> wrote: >>> On Mon, Nov 12, 2012 at 7:45 AM, Axel Lin wrote: >>> Use managed resources API to simplify the code. Also e

Re: [PATCH 1/2] pinctrl: pxa3xx: Use devm_request_and_ioremap

2012-11-15 Thread Linus Walleij
On Wed, Nov 14, 2012 at 2:47 AM, Haojian Zhuang wrote: > On Tue, Nov 13, 2012 at 10:33 PM, Linus Walleij > wrote: >> On Mon, Nov 12, 2012 at 7:45 AM, Axel Lin wrote: >> >>> Use managed resources API to simplify the code. >>> Also ensure we do request mem_region before ioremap. >>> >>> Signed-off

Re: [PATCH 1/2] pinctrl: pxa3xx: Use devm_request_and_ioremap

2012-11-13 Thread Haojian Zhuang
On Tue, Nov 13, 2012 at 10:33 PM, Linus Walleij wrote: > On Mon, Nov 12, 2012 at 7:45 AM, Axel Lin wrote: > >> Use managed resources API to simplify the code. >> Also ensure we do request mem_region before ioremap. >> >> Signed-off-by: Axel Lin > > Obviously correct, patch applied. > > Yours, >

Re: [PATCH 1/2] pinctrl: pxa3xx: Use devm_request_and_ioremap

2012-11-13 Thread Linus Walleij
On Mon, Nov 12, 2012 at 7:45 AM, Axel Lin wrote: > Use managed resources API to simplify the code. > Also ensure we do request mem_region before ioremap. > > Signed-off-by: Axel Lin Obviously correct, patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscr

[PATCH 1/2] pinctrl: pxa3xx: Use devm_request_and_ioremap

2012-11-11 Thread Axel Lin
Use managed resources API to simplify the code. Also ensure we do request mem_region before ioremap. Signed-off-by: Axel Lin --- drivers/pinctrl/pinctrl-pxa3xx.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/pinctrl/pinctrl-pxa3xx.c b/drivers/pinctrl/pi