Re: [PATCH 1/2] perf stat: refactor aggregation code

2013-02-13 Thread Stephane Eranian
On Wed, Feb 13, 2013 at 8:50 AM, Namhyung Kim wrote: > Hi Stephane, > > On Tue, 12 Feb 2013 15:09:27 +0100, Stephane Eranian wrote: >> Refactor aggregation code by introducing >> a single aggr_mode variable and an enum >> for aggregation. >> >> Also refactor cpumap code having to do >> with cpu to

Re: [PATCH 1/2] perf stat: refactor aggregation code

2013-02-12 Thread Namhyung Kim
Hi Stephane, On Tue, 12 Feb 2013 15:09:27 +0100, Stephane Eranian wrote: > Refactor aggregation code by introducing > a single aggr_mode variable and an enum > for aggregation. > > Also refactor cpumap code having to do > with cpu to socket mappings. All in preparation > for extended modes, such a

Re: [PATCH 1/2] perf stat: refactor aggregation code

2013-02-12 Thread Andi Kleen
On Tue, Feb 12, 2013 at 03:09:27PM +0100, Stephane Eranian wrote: > - fmt = "%s%.0f%s%s"; > + fmt = "%.0f%s%s"; > else if (big_num) > - fmt = "%s%'18.0f%s%-25s"; > + fmt = "%'18.0f%s%-25s"; > else > - fmt = "%s%18.0f%s%-25s"; >

[PATCH 1/2] perf stat: refactor aggregation code

2013-02-12 Thread Stephane Eranian
Refactor aggregation code by introducing a single aggr_mode variable and an enum for aggregation. Also refactor cpumap code having to do with cpu to socket mappings. All in preparation for extended modes, such as cpu -> core. Also fix socket aggregation and ensure that sockets are printed in incr