Re: [PATCH 1/2] perf sched: Prefer sched_waking event when it exists

2020-08-12 Thread Arnaldo Carvalho de Melo
Em Tue, Aug 11, 2020 at 03:42:45PM +0900, Namhyung Kim escreveu: > Hi David, > > On Sat, Aug 8, 2020 at 1:48 AM David Ahern wrote: > > > > Commit fbd705a0c618 ("sched: Introduce the 'trace_sched_waking' tracepoint") > > added sched_waking tracepoint which should be preferred over sched_wakeup > >

Re: [PATCH 1/2] perf sched: Prefer sched_waking event when it exists

2020-08-10 Thread Namhyung Kim
Hi David, On Sat, Aug 8, 2020 at 1:48 AM David Ahern wrote: > > Commit fbd705a0c618 ("sched: Introduce the 'trace_sched_waking' tracepoint") > added sched_waking tracepoint which should be preferred over sched_wakeup > when analyzing scheduling delays. > > Update 'perf sched record' to collect sc

Re: [PATCH 1/2] perf sched: Prefer sched_waking event when it exists

2020-08-10 Thread Arnaldo Carvalho de Melo
Em Fri, Aug 07, 2020 at 01:50:47PM -0600, David Ahern escreveu: > On 8/7/20 1:43 PM, Arnaldo Carvalho de Melo wrote: > >> @@ -2958,9 +2967,10 @@ static int timehist_check_attr(struct perf_sched > >> *sched, > >> > >> static int perf_sched__timehist(struct perf_sched *sched) > >> { > >> - cons

Re: [PATCH 1/2] perf sched: Prefer sched_waking event when it exists

2020-08-07 Thread David Ahern
On 8/7/20 1:43 PM, Arnaldo Carvalho de Melo wrote: >> @@ -2958,9 +2967,10 @@ static int timehist_check_attr(struct perf_sched >> *sched, >> >> static int perf_sched__timehist(struct perf_sched *sched) >> { >> -const struct evsel_str_handler handlers[] = { >> +struct evsel_str_handler h

Re: [PATCH 1/2] perf sched: Prefer sched_waking event when it exists

2020-08-07 Thread Arnaldo Carvalho de Melo
Em Fri, Aug 07, 2020 at 10:48:44AM -0600, David Ahern escreveu: > Commit fbd705a0c618 ("sched: Introduce the 'trace_sched_waking' tracepoint") > added sched_waking tracepoint which should be preferred over sched_wakeup > when analyzing scheduling delays. > > Update 'perf sched record' to collect s

[PATCH 1/2] perf sched: Prefer sched_waking event when it exists

2020-08-07 Thread David Ahern
Commit fbd705a0c618 ("sched: Introduce the 'trace_sched_waking' tracepoint") added sched_waking tracepoint which should be preferred over sched_wakeup when analyzing scheduling delays. Update 'perf sched record' to collect sched_waking events if it exists and fallback to sched_wakeup if it does no