Re: [PATCH 1/2] perf: add container identifier entry in perf sample data

2016-08-25 Thread Ananth N Mavinakayanahalli
On Thu, Aug 25, 2016 at 10:50:18PM +0530, Hari Bathini wrote: > > > On Thursday 25 August 2016 06:31 PM, Peter Zijlstra wrote: > >On Thu, Aug 25, 2016 at 05:27:54PM +0530, Hari Bathini wrote: > > > >>diff --git a/include/uapi/linux/perf_event.h > >>b/include/uapi/linux/perf_event.h > >>index c66

Re: [PATCH 1/2] perf: add container identifier entry in perf sample data

2016-08-25 Thread Hari Bathini
On Thursday 25 August 2016 06:31 PM, Peter Zijlstra wrote: On Thu, Aug 25, 2016 at 05:27:54PM +0530, Hari Bathini wrote: diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h index c66a485..fb4f902 100644 --- a/include/uapi/linux/perf_event.h +++ b/include/uapi/linux/

Re: [PATCH 1/2] perf: add container identifier entry in perf sample data

2016-08-25 Thread Peter Zijlstra
On Thu, Aug 25, 2016 at 10:50:18PM +0530, Hari Bathini wrote: > Actually, on second thought, how about using inode number of some > other namespace that any container would have (mount, probably?).. I have no clue about those things. The only thing I can tell you is that you get to pick once ;-)

[PATCH 1/2] perf: add container identifier entry in perf sample data

2016-08-25 Thread Hari Bathini
Currently, there is no mechanism to filter events based on containers. perf -g can be used, but it will not filter events for the containers created after perf is invoked, making it difficult to assess/analyze performance issues of multiple containers at once. This limitation can be overcome, if th

Re: [PATCH 1/2] perf: add container identifier entry in perf sample data

2016-08-25 Thread Peter Zijlstra
On Thu, Aug 25, 2016 at 05:27:54PM +0530, Hari Bathini wrote: > diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h > index c66a485..fb4f902 100644 > --- a/include/uapi/linux/perf_event.h > +++ b/include/uapi/linux/perf_event.h > @@ -139,8 +139,9 @@ enum perf_event_sampl