Re: [PATCH 1/2] perf: Reset detached siblings' group_flags

2013-03-11 Thread Namhyung Kim
While looking at the code again, I found that the detached siblings should call perf_event__header_size() for themselves in the loop since after moving them to the list the previous leader will have empty sibling_list. Something like below is needed IMHO: diff --git a/kernel/events/core.c b/kern

Re: [PATCH 1/2] perf: Reset detached siblings' group_flags

2013-03-11 Thread Namhyung Kim
On Mon, 11 Mar 2013 10:59:44 +0100, Peter Zijlstra wrote: > On Thu, 2013-03-07 at 13:19 +0900, Namhyung Kim wrote: >> From: Namhyung Kim >> >> Currently if a group_leader event is deleted, the sibling events are >> upgraded to singleton events of a same group list. At this time, the >> siblings

Re: [PATCH 1/2] perf: Reset detached siblings' group_flags

2013-03-11 Thread Peter Zijlstra
On Thu, 2013-03-07 at 13:19 +0900, Namhyung Kim wrote: > From: Namhyung Kim > > Currently if a group_leader event is deleted, the sibling events are > upgraded to singleton events of a same group list. At this time, the > siblings inherit the leader's group_flags. > > However, if the group has

[PATCH 1/2] perf: Reset detached siblings' group_flags

2013-03-06 Thread Namhyung Kim
From: Namhyung Kim Currently if a group_leader event is deleted, the sibling events are upgraded to singleton events of a same group list. At this time, the siblings inherit the leader's group_flags. However, if the group has mixed hw/sw events the leader's group_flag does not contain PERF_GROU