Re: [PATCH 1/2] pci: endpoint: Free func_name after last usage

2018-02-23 Thread Lorenzo Pieralisi
On Fri, Feb 23, 2018 at 06:38:42PM +0100, Rolf Evers-Fischer wrote: > Hi Kishon, > > On Fri, 23 Feb 2018, Kishon Vijay Abraham I wrote: > > On Friday 23 February 2018 03:06 PM, Lorenzo Pieralisi wrote: > > > On Fri, Feb 23, 2018 at 11:40:49AM +0530, Kishon Vijay Abraham I wrote: > > >> Hi Lorenzo,

Re: [PATCH 1/2] pci: endpoint: Free func_name after last usage

2018-02-23 Thread Rolf Evers-Fischer
Hi Kishon, On Fri, 23 Feb 2018, Kishon Vijay Abraham I wrote: > On Friday 23 February 2018 03:06 PM, Lorenzo Pieralisi wrote: > > On Fri, Feb 23, 2018 at 11:40:49AM +0530, Kishon Vijay Abraham I wrote: > >> Hi Lorenzo, > >> > >> On Thursday 22 February 2018 11:49 PM, Lorenzo Pieralisi wrote: > >>>

Re: [PATCH 1/2] pci: endpoint: Free func_name after last usage

2018-02-23 Thread Kishon Vijay Abraham I
On Friday 23 February 2018 03:06 PM, Lorenzo Pieralisi wrote: > On Fri, Feb 23, 2018 at 11:40:49AM +0530, Kishon Vijay Abraham I wrote: >> Hi Lorenzo, >> >> On Thursday 22 February 2018 11:49 PM, Lorenzo Pieralisi wrote: >>> On Wed, Feb 21, 2018 at 01:47:06PM +0100, Rolf Evers-Fischer wrote:

Re: [PATCH 1/2] pci: endpoint: Free func_name after last usage

2018-02-23 Thread Lorenzo Pieralisi
On Fri, Feb 23, 2018 at 11:40:49AM +0530, Kishon Vijay Abraham I wrote: > Hi Lorenzo, > > On Thursday 22 February 2018 11:49 PM, Lorenzo Pieralisi wrote: > > On Wed, Feb 21, 2018 at 01:47:06PM +0100, Rolf Evers-Fischer wrote: > >> From: Rolf Evers-Fischer > >> > >> This commit decreases the numbe

Re: [PATCH 1/2] pci: endpoint: Free func_name after last usage

2018-02-22 Thread Kishon Vijay Abraham I
Hi Lorenzo, On Thursday 22 February 2018 11:49 PM, Lorenzo Pieralisi wrote: > On Wed, Feb 21, 2018 at 01:47:06PM +0100, Rolf Evers-Fischer wrote: >> From: Rolf Evers-Fischer >> >> This commit decreases the number of jump labels and ensures >> that the next commit doesn't increase the number of oc

Re: [PATCH 1/2] pci: endpoint: Free func_name after last usage

2018-02-22 Thread Lorenzo Pieralisi
On Wed, Feb 21, 2018 at 01:47:06PM +0100, Rolf Evers-Fischer wrote: > From: Rolf Evers-Fischer > > This commit decreases the number of jump labels and ensures > that the next commit doesn't increase the number of occurrences > of 'kfree(func_name)'. > > Change-Id: I0d1b6fd652395b85f82b11c43bf9b7

Re: [PATCH 1/2] pci: endpoint: Free func_name after last usage

2018-02-22 Thread Andy Shevchenko
On Thu, Feb 22, 2018 at 6:21 PM, Rolf Evers-Fischer wrote: > On Wed, 21 Feb 2018, Andy Shevchenko wrote: >> This is a slow path and your change makes code slightly less readable >> b/c of patterns used in the kernel. >> > I see. It is probably not a good idea to free the > memory in the middle of

Re: [PATCH 1/2] pci: endpoint: Free func_name after last usage

2018-02-22 Thread Rolf Evers-Fischer
On Wed, 21 Feb 2018, Andy Shevchenko wrote: > > Change-Id: I0d1b6fd652395b85f82b11c43bf9b7db512854d1 > > First of all, this shouldn't be here. > Please excuse me. I know that I have to remove this, but unfortunately I forgot to do so (here and also in the other patch). > > Signed-off-by: Rolf

Re: [PATCH 1/2] pci: endpoint: Free func_name after last usage

2018-02-21 Thread Andy Shevchenko
On Wed, Feb 21, 2018 at 2:47 PM, Rolf Evers-Fischer wrote: > This commit decreases the number of jump labels and ensures > that the next commit doesn't increase the number of occurrences > of 'kfree(func_name)'. > Change-Id: I0d1b6fd652395b85f82b11c43bf9b7db512854d1 First of all, this shouldn't

[PATCH 1/2] pci: endpoint: Free func_name after last usage

2018-02-21 Thread Rolf Evers-Fischer
From: Rolf Evers-Fischer This commit decreases the number of jump labels and ensures that the next commit doesn't increase the number of occurrences of 'kfree(func_name)'. Change-Id: I0d1b6fd652395b85f82b11c43bf9b7db512854d1 Signed-off-by: Rolf Evers-Fischer Signed-off-by: Rolf Evers-Fischer -