Re: [PATCH 1/2] of_pci_irq: add a check to fallback to standard device tree parsing

2018-03-15 Thread Ryder Lee
On Thu, 2018-03-15 at 17:43 +, Lorenzo Pieralisi wrote: > On Wed, Jan 31, 2018 at 03:41:49PM +0800, Ryder Lee wrote: > > A root complex usually consist of a host bridge and multiple P2P bridges, > > and someone may express that in the form of a root node with many subnodes > > and list all four

Re: [PATCH 1/2] of_pci_irq: add a check to fallback to standard device tree parsing

2018-03-15 Thread Lorenzo Pieralisi
On Wed, Jan 31, 2018 at 03:41:49PM +0800, Ryder Lee wrote: > A root complex usually consist of a host bridge and multiple P2P bridges, > and someone may express that in the form of a root node with many subnodes > and list all four interrupts for each slot (child node) in the root node > like this:

Re: [PATCH 1/2] of_pci_irq: add a check to fallback to standard device tree parsing

2018-02-06 Thread Ryder Lee
Hi, Arnd On Wed, 2018-02-07 at 09:31 +1100, Benjamin Herrenschmidt wrote: > On Tue, 2018-02-06 at 13:42 +0800, Ryder Lee wrote: > > Thanks for explanation. > > > > So I guess the better way to achieve my aim - one IRQ per slot that is > > connected to all INTx and get propagated through the bridg

Re: [PATCH 1/2] of_pci_irq: add a check to fallback to standard device tree parsing

2018-02-06 Thread Benjamin Herrenschmidt
On Tue, 2018-02-06 at 13:42 +0800, Ryder Lee wrote: > Thanks for explanation. > > So I guess the better way to achieve my aim - one IRQ per slot that is > connected to all INTx and get propagated through the bridges (and for > those root ports own interrupts (PME ..)} is to add interrupt-map > pro

Re: [PATCH 1/2] of_pci_irq: add a check to fallback to standard device tree parsing

2018-02-05 Thread Ryder Lee
On Tue, 2018-02-06 at 15:50 +1100, Benjamin Herrenschmidt wrote: > On Tue, 2018-02-06 at 12:31 +0800, Ryder Lee wrote: > > On Tue, 2018-02-06 at 15:05 +1100, Benjamin Herrenschmidt wrote: > > > On Tue, 2018-02-06 at 10:38 +0800, Ryder Lee wrote: > > > > > > > > I think the code should look at the

Re: [PATCH 1/2] of_pci_irq: add a check to fallback to standard device tree parsing

2018-02-05 Thread Benjamin Herrenschmidt
On Tue, 2018-02-06 at 12:31 +0800, Ryder Lee wrote: > On Tue, 2018-02-06 at 15:05 +1100, Benjamin Herrenschmidt wrote: > > On Tue, 2018-02-06 at 10:38 +0800, Ryder Lee wrote: > > > > > > I think the code should look at the bridge address <0x0800 ...> we list > > > in bindings for resolving interru

Re: [PATCH 1/2] of_pci_irq: add a check to fallback to standard device tree parsing

2018-02-05 Thread Ryder Lee
On Tue, 2018-02-06 at 15:05 +1100, Benjamin Herrenschmidt wrote: > On Tue, 2018-02-06 at 10:38 +0800, Ryder Lee wrote: > > > > I think the code should look at the bridge address <0x0800 ...> we list > > in bindings for resolving interrupts in this case, but it seems like it > > use the 'pdev->defv

Re: [PATCH 1/2] of_pci_irq: add a check to fallback to standard device tree parsing

2018-02-05 Thread Benjamin Herrenschmidt
On Tue, 2018-02-06 at 10:38 +0800, Ryder Lee wrote: > > I think the code should look at the bridge address <0x0800 ...> we list > in bindings for resolving interrupts in this case, but it seems like it > use the 'pdev->defvn << 8' which is not really we want and will lead to > mismatch. > >

Re: [PATCH 1/2] of_pci_irq: add a check to fallback to standard device tree parsing

2018-02-05 Thread Ryder Lee
On Tue, 2018-02-06 at 08:36 +1100, Benjamin Herrenschmidt wrote: > On Fri, 2018-02-02 at 17:32 +0800, Ryder Lee wrote: > > On Wed, 2018-01-31 at 10:02 -0600, Rob Herring wrote: > > > On Wed, Jan 31, 2018 at 1:41 AM, Ryder Lee wrote: > > > > A root complex usually consist of a host bridge and multi

Re: [PATCH 1/2] of_pci_irq: add a check to fallback to standard device tree parsing

2018-02-05 Thread Benjamin Herrenschmidt
On Fri, 2018-02-02 at 17:32 +0800, Ryder Lee wrote: > On Wed, 2018-01-31 at 10:02 -0600, Rob Herring wrote: > > On Wed, Jan 31, 2018 at 1:41 AM, Ryder Lee wrote: > > > A root complex usually consist of a host bridge and multiple P2P bridges, > > > and someone may express that in the form of a root

Re: [PATCH 1/2] of_pci_irq: add a check to fallback to standard device tree parsing

2018-02-02 Thread Ryder Lee
On Wed, 2018-01-31 at 10:02 -0600, Rob Herring wrote: > On Wed, Jan 31, 2018 at 1:41 AM, Ryder Lee wrote: > > A root complex usually consist of a host bridge and multiple P2P bridges, > > and someone may express that in the form of a root node with many subnodes > > and list all four interrupts fo

Re: [PATCH 1/2] of_pci_irq: add a check to fallback to standard device tree parsing

2018-01-31 Thread Rob Herring
On Wed, Jan 31, 2018 at 1:41 AM, Ryder Lee wrote: > A root complex usually consist of a host bridge and multiple P2P bridges, > and someone may express that in the form of a root node with many subnodes > and list all four interrupts for each slot (child node) in the root node > like this: > >

[PATCH 1/2] of_pci_irq: add a check to fallback to standard device tree parsing

2018-01-30 Thread Ryder Lee
A root complex usually consist of a host bridge and multiple P2P bridges, and someone may express that in the form of a root node with many subnodes and list all four interrupts for each slot (child node) in the root node like this: pcie-controller { ... int