Re: [PATCH 1/2] of: base: add support to get machine model name

2016-12-12 Thread Rob Herring
On Fri, Dec 9, 2016 at 5:54 PM, Frank Rowand wrote: > On 12/09/16 08:03, Rob Herring wrote: >> On Wed, Nov 23, 2016 at 4:25 AM, Sudeep Holla wrote: >>> >>> >>> On 22/11/16 21:35, Rob Herring wrote: On Tue, Nov 22, 2016 at 12:44 PM, Frank Rowand wrote: >>> >>> >>> [...] >>> > >

Re: [PATCH 1/2] of: base: add support to get machine model name

2016-12-09 Thread Frank Rowand
On 12/09/16 08:03, Rob Herring wrote: > On Wed, Nov 23, 2016 at 4:25 AM, Sudeep Holla wrote: >> >> >> On 22/11/16 21:35, Rob Herring wrote: >>> >>> On Tue, Nov 22, 2016 at 12:44 PM, Frank Rowand >>> wrote: >> >> >> [...] >> This patch adds a function that leads to conflating the "model"

Re: [PATCH 1/2] of: base: add support to get machine model name

2016-12-09 Thread Rob Herring
On Wed, Nov 23, 2016 at 4:25 AM, Sudeep Holla wrote: > > > On 22/11/16 21:35, Rob Herring wrote: >> >> On Tue, Nov 22, 2016 at 12:44 PM, Frank Rowand >> wrote: > > > [...] > >>> >>> This patch adds a function that leads to conflating the "model" property >>> and the "compatible" property. This le

Re: [PATCH 1/2] of: base: add support to get machine model name

2016-11-23 Thread Sudeep Holla
On 22/11/16 18:44, Frank Rowand wrote: Hi Rob, [...] This patch adds a function that leads to conflating the "model" property and the "compatible" property. This leads to opaque, confusing and unclear code where ever it is used. I think it is not good for the device tree framework to con

Re: [PATCH 1/2] of: base: add support to get machine model name

2016-11-23 Thread Sudeep Holla
On 22/11/16 21:35, Rob Herring wrote: On Tue, Nov 22, 2016 at 12:44 PM, Frank Rowand wrote: [...] This patch adds a function that leads to conflating the "model" property and the "compatible" property. This leads to opaque, confusing and unclear code where ever it is used. I think it is

Re: [PATCH 1/2] of: base: add support to get machine model name

2016-11-22 Thread Rob Herring
On Tue, Nov 22, 2016 at 12:44 PM, Frank Rowand wrote: > Hi Rob, > > On 11/18/16 12:00, Frank Rowand wrote: >> On 11/18/16 06:46, Rob Herring wrote: >>> On Thu, Nov 17, 2016 at 03:32:54PM +, Sudeep Holla wrote: Currently platforms/drivers needing to get the machine model name are repl

Re: [PATCH 1/2] of: base: add support to get machine model name

2016-11-22 Thread Frank Rowand
Hi Rob, On 11/18/16 12:00, Frank Rowand wrote: > On 11/18/16 06:46, Rob Herring wrote: >> On Thu, Nov 17, 2016 at 03:32:54PM +, Sudeep Holla wrote: >>> Currently platforms/drivers needing to get the machine model name are >>> replicating the same snippet of code. In some case, the OF reference

Re: [PATCH 1/2] of: base: add support to get machine model name

2016-11-21 Thread Frank Rowand
On 11/21/16 11:24, Frank Rowand wrote: > On 11/21/16 08:23, Sudeep Holla wrote: >> >> >> On 21/11/16 16:05, Frank Rowand wrote: >>> Hi Sudeep, >>> >>> On 11/18/16 12:22, Frank Rowand wrote: On 11/18/16 02:41, Sudeep Holla wrote: > > > On 17/11/16 21:00, Frank Rowand wrote: >> O

Re: [PATCH 1/2] of: base: add support to get machine model name

2016-11-21 Thread Frank Rowand
On 11/21/16 08:20, Sudeep Holla wrote: > > > On 18/11/16 20:22, Frank Rowand wrote: >> On 11/18/16 02:41, Sudeep Holla wrote: >>> >>> >>> On 17/11/16 21:00, Frank Rowand wrote: On 11/17/16 07:32, Sudeep Holla wrote: > Currently platforms/drivers needing to get the machine model name are

Re: [PATCH 1/2] of: base: add support to get machine model name

2016-11-21 Thread Frank Rowand
On 11/21/16 08:23, Sudeep Holla wrote: > > > On 21/11/16 16:05, Frank Rowand wrote: >> Hi Sudeep, >> >> On 11/18/16 12:22, Frank Rowand wrote: >>> On 11/18/16 02:41, Sudeep Holla wrote: On 17/11/16 21:00, Frank Rowand wrote: > On 11/17/16 07:32, Sudeep Holla wrote: >> Curre

Re: [PATCH 1/2] of: base: add support to get machine model name

2016-11-21 Thread Sudeep Holla
On 21/11/16 16:05, Frank Rowand wrote: Hi Sudeep, On 11/18/16 12:22, Frank Rowand wrote: On 11/18/16 02:41, Sudeep Holla wrote: On 17/11/16 21:00, Frank Rowand wrote: On 11/17/16 07:32, Sudeep Holla wrote: Currently platforms/drivers needing to get the machine model name are replicating

Re: [PATCH 1/2] of: base: add support to get machine model name

2016-11-21 Thread Sudeep Holla
On 18/11/16 20:22, Frank Rowand wrote: On 11/18/16 02:41, Sudeep Holla wrote: On 17/11/16 21:00, Frank Rowand wrote: On 11/17/16 07:32, Sudeep Holla wrote: Currently platforms/drivers needing to get the machine model name are replicating the same snippet of code. In some case, the OF refer

Re: [PATCH 1/2] of: base: add support to get machine model name

2016-11-21 Thread Frank Rowand
Hi Sudeep, On 11/18/16 12:22, Frank Rowand wrote: > On 11/18/16 02:41, Sudeep Holla wrote: >> >> >> On 17/11/16 21:00, Frank Rowand wrote: >>> On 11/17/16 07:32, Sudeep Holla wrote: Currently platforms/drivers needing to get the machine model name are replicating the same snippet of code

Re: [PATCH 1/2] of: base: add support to get machine model name

2016-11-18 Thread Frank Rowand
On 11/18/16 02:41, Sudeep Holla wrote: > > > On 17/11/16 21:00, Frank Rowand wrote: >> On 11/17/16 07:32, Sudeep Holla wrote: >>> Currently platforms/drivers needing to get the machine model name are >>> replicating the same snippet of code. In some case, the OF reference >>> counting is either m

Re: [PATCH 1/2] of: base: add support to get machine model name

2016-11-18 Thread Frank Rowand
On 11/18/16 06:46, Rob Herring wrote: > On Thu, Nov 17, 2016 at 03:32:54PM +, Sudeep Holla wrote: >> Currently platforms/drivers needing to get the machine model name are >> replicating the same snippet of code. In some case, the OF reference >> counting is either missing or incorrect. >> >> Th

Re: [PATCH 1/2] of: base: add support to get machine model name

2016-11-18 Thread Rob Herring
On Thu, Nov 17, 2016 at 03:32:54PM +, Sudeep Holla wrote: > Currently platforms/drivers needing to get the machine model name are > replicating the same snippet of code. In some case, the OF reference > counting is either missing or incorrect. > > This patch adds support to read the machine mo

Re: [PATCH 1/2] of: base: add support to get machine model name

2016-11-18 Thread Sudeep Holla
On 17/11/16 21:00, Frank Rowand wrote: On 11/17/16 07:32, Sudeep Holla wrote: Currently platforms/drivers needing to get the machine model name are replicating the same snippet of code. In some case, the OF reference counting is either missing or incorrect. This patch adds support to read the

Re: [PATCH 1/2] of: base: add support to get machine model name

2016-11-17 Thread Frank Rowand
On 11/17/16 13:00, Frank Rowand wrote: > On 11/17/16 07:32, Sudeep Holla wrote: >> Currently platforms/drivers needing to get the machine model name are >> replicating the same snippet of code. In some case, the OF reference >> counting is either missing or incorrect. >> >> This patch adds support

Re: [PATCH 1/2] of: base: add support to get machine model name

2016-11-17 Thread Frank Rowand
On 11/17/16 07:32, Sudeep Holla wrote: > Currently platforms/drivers needing to get the machine model name are > replicating the same snippet of code. In some case, the OF reference > counting is either missing or incorrect. > > This patch adds support to read the machine model name either using >

[PATCH 1/2] of: base: add support to get machine model name

2016-11-17 Thread Sudeep Holla
Currently platforms/drivers needing to get the machine model name are replicating the same snippet of code. In some case, the OF reference counting is either missing or incorrect. This patch adds support to read the machine model name either using the "model" or the "compatible" property in the de