Re: [PATCH 1/2] net: ethernet: bgmac: init sequence bug

2017-02-02 Thread Rafał Miłecki
On 2017-02-02 01:31, Zac Schroff wrote: How about BCMA_IOCTL_PRESERVE_ACROSS_INIT? I think wireless drivers may still set some these bits during init. I've a simpler idea: make it bgmac specific. Call it sth like BGMAC_BCMA_IOCTL_PRESERVE BGMAC_BCMA_IOCTL_RESERVED BGMAC_BCMA_IOCTL_DONT_TOUCH

Re: [PATCH 1/2] net: ethernet: bgmac: init sequence bug

2017-02-02 Thread Jon Mason
On Thu, Feb 2, 2017 at 3:15 PM, Rafał Miłecki wrote: > On 2017-02-02 01:31, Zac Schroff wrote: >> >> How about BCMA_IOCTL_PRESERVE_ACROSS_INIT? > > > I think wireless drivers may still set some these bits during init. > > I've a simpler idea: make it bgmac specific. Call it sth like > BGMAC_BCMA_I

Re: [PATCH 1/2] net: ethernet: bgmac: init sequence bug

2017-02-02 Thread Jon Mason
On Wed, Feb 1, 2017 at 6:06 PM, Rafał Miłecki wrote: > On 02/01/2017 11:39 PM, Jon Mason wrote: >> >> From: Zac Schroff >> >> Fix a bug in the 'bgmac' driver init sequence that blind writes for init >> sequence where it should preserve most bits other than the ones it is >> deliberately manipulat

Re: [PATCH 1/2] net: ethernet: bgmac: init sequence bug

2017-02-02 Thread Sergei Shtylyov
Hello! On 2/2/2017 1:39 AM, Jon Mason wrote: From: Zac Schroff Fix a bug in the 'bgmac' driver init sequence that blind writes for init sequence where it should preserve most bits other than the ones it is deliberately manipulating. Signed-off-by: Zac Schroff Signed-off-by: Jon Mason Fixes

Re: [PATCH 1/2] net: ethernet: bgmac: init sequence bug

2017-02-01 Thread Zac Schroff
How about BCMA_IOCTL_PRESERVE_ACROSS_INIT? On Wed, Feb 1, 2017 at 6:06 PM, Rafał Miłecki wrote: > On 02/01/2017 11:39 PM, Jon Mason wrote: >> >> From: Zac Schroff >> >> Fix a bug in the 'bgmac' driver init sequence that blind writes for init >> sequence where it should preserve most bits other t

Re: [PATCH 1/2] net: ethernet: bgmac: init sequence bug

2017-02-01 Thread Rafał Miłecki
On 02/01/2017 11:39 PM, Jon Mason wrote: From: Zac Schroff Fix a bug in the 'bgmac' driver init sequence that blind writes for init sequence where it should preserve most bits other than the ones it is deliberately manipulating. Signed-off-by: Zac Schroff Signed-off-by: Jon Mason Fixes: f6a9

[PATCH 1/2] net: ethernet: bgmac: init sequence bug

2017-02-01 Thread Jon Mason
From: Zac Schroff Fix a bug in the 'bgmac' driver init sequence that blind writes for init sequence where it should preserve most bits other than the ones it is deliberately manipulating. Signed-off-by: Zac Schroff Signed-off-by: Jon Mason Fixes: f6a95a24957 ("net: ethernet: bgmac: Add platfor