Re: [PATCH 1/2] net: dsa: mv88e6xxx: Add EEE support

2015-03-07 Thread David Miller
From: Guenter Roeck Date: Fri, 6 Mar 2015 22:23:51 -0800 > EEE configuration is similar for the various MV88E6xxx chips. > Add generic support for it. > > Signed-off-by: Guenter Roeck > Reviewed-by: Florian Fainelli Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-

[PATCH 1/2] net: dsa: mv88e6xxx: Add EEE support

2015-03-06 Thread Guenter Roeck
EEE configuration is similar for the various MV88E6xxx chips. Add generic support for it. Signed-off-by: Guenter Roeck Reviewed-by: Florian Fainelli --- Changes since RFT: - Additional testing; no code changes - Dropped comment about phy_init_eee drivers/net/dsa/mv88e6xxx.c | 51 ++

Re: [RFT PATCH 1/2] net: dsa: mv88e6xxx: Add EEE support

2015-02-23 Thread Florian Fainelli
On 23/02/15 18:29, Guenter Roeck wrote: > On 02/23/2015 02:19 PM, David Miller wrote: >> From: Guenter Roeck >> Date: Mon, 23 Feb 2015 08:26:09 -0800 >> >>> +/* Don't call phy_init_eee for now. It fails if the link is down, >>> + * but that should not really be a reason to fail configurati

Re: [RFT PATCH 1/2] net: dsa: mv88e6xxx: Add EEE support

2015-02-23 Thread Guenter Roeck
On 02/23/2015 02:19 PM, David Miller wrote: From: Guenter Roeck Date: Mon, 23 Feb 2015 08:26:09 -0800 + /* Don't call phy_init_eee for now. It fails if the link is down, +* but that should not really be a reason to fail configuration. +*/ I think there is some confusion

Re: [RFT PATCH 1/2] net: dsa: mv88e6xxx: Add EEE support

2015-02-23 Thread David Miller
From: Guenter Roeck Date: Mon, 23 Feb 2015 08:26:09 -0800 > + /* Don't call phy_init_eee for now. It fails if the link is down, > + * but that should not really be a reason to fail configuration. > + */ I think there is some confusion about phy_init_eee(). You invoke it after a li

Re: [RFT PATCH 1/2] net: dsa: mv88e6xxx: Add EEE support

2015-02-23 Thread Florian Fainelli
On 23/02/15 10:52, Guenter Roeck wrote: > On Mon, Feb 23, 2015 at 09:45:01AM -0800, Florian Fainelli wrote: >> On 23/02/15 08:26, Guenter Roeck wrote: >>> EEE configuration is similar for the various MV88E6xxx chips. >>> Add generic support for it. >>> >>> Signed-off-by: Guenter Roeck >> >> Review

Re: [RFT PATCH 1/2] net: dsa: mv88e6xxx: Add EEE support

2015-02-23 Thread Guenter Roeck
On Mon, Feb 23, 2015 at 09:45:01AM -0800, Florian Fainelli wrote: > On 23/02/15 08:26, Guenter Roeck wrote: > > EEE configuration is similar for the various MV88E6xxx chips. > > Add generic support for it. > > > > Signed-off-by: Guenter Roeck > > Reviewed-by: Florian Fainelli > > > --- > > App

Re: [RFT PATCH 1/2] net: dsa: mv88e6xxx: Add EEE support

2015-02-23 Thread Florian Fainelli
On 23/02/15 08:26, Guenter Roeck wrote: > EEE configuration is similar for the various MV88E6xxx chips. > Add generic support for it. > > Signed-off-by: Guenter Roeck Reviewed-by: Florian Fainelli > --- > Applies to net-next. > > The code seems to be working, at least according to ethtool, bu

[RFT PATCH 1/2] net: dsa: mv88e6xxx: Add EEE support

2015-02-23 Thread Guenter Roeck
EEE configuration is similar for the various MV88E6xxx chips. Add generic support for it. Signed-off-by: Guenter Roeck --- Applies to net-next. The code seems to be working, at least according to ethtool, but some more testing with other chip types would be useful. Also, I am not sure what to do