Re: [PATCH 1/2] mm: mmap: Add new /proc tunable for mmap_base ASLR.

2015-11-03 Thread Daniel Cashman
On 11/01/2015 01:50 PM, Eric W. Biederman wrote: > Daniel Cashman writes: > >> On 10/28/2015 08:41 PM, Eric W. Biederman wrote: >>> Dan Cashman writes: >>> >> This all would be much cleaner if the arm architecture code were just to >> register the sysctl itself. >> >> As it sits

Re: [PATCH 1/2] mm: mmap: Add new /proc tunable for mmap_base ASLR.

2015-11-01 Thread Eric W. Biederman
Daniel Cashman writes: > On 10/28/2015 08:41 PM, Eric W. Biederman wrote: >> Dan Cashman writes: >> > This all would be much cleaner if the arm architecture code were just to > register the sysctl itself. > > As it sits this looks like a patchset that does not meaninfully bisect

Re: [PATCH 1/2] mm: mmap: Add new /proc tunable for mmap_base ASLR.

2015-10-29 Thread Daniel Cashman
On 10/28/2015 08:41 PM, Eric W. Biederman wrote: > Dan Cashman writes: > This all would be much cleaner if the arm architecture code were just to register the sysctl itself. As it sits this looks like a patchset that does not meaninfully bisect, and would result in code t

Re: [PATCH 1/2] mm: mmap: Add new /proc tunable for mmap_base ASLR.

2015-10-28 Thread Eric W. Biederman
Dan Cashman writes: >> > This all would be much cleaner if the arm architecture code were just to >> > register the sysctl itself. >> > >> > As it sits this looks like a patchset that does not meaninfully bisect, >> > and would result in code that is hard to trace and understand. >> >> I believe

Re: [PATCH 1/2] mm: mmap: Add new /proc tunable for mmap_base ASLR.

2015-10-28 Thread Dan Cashman
> > This all would be much cleaner if the arm architecture code were just to > > register the sysctl itself. > > > > As it sits this looks like a patchset that does not meaninfully bisect, > > and would result in code that is hard to trace and understand. > > I believe the intent is to follow up wi

Re: [PATCH 1/2] mm: mmap: Add new /proc tunable for mmap_base ASLR.

2015-10-28 Thread Jeffrey Vander Stoep
plain text this time... > This all would be much cleaner if the arm architecture code were just to > register the sysctl itself. > > As it sits this looks like a patchset that does not meaninfully bisect, > and would result in code that is hard to trace and understand. I believe the intent is to

Re: [PATCH 1/2] mm: mmap: Add new /proc tunable for mmap_base ASLR.

2015-10-28 Thread Eric W. Biederman
Daniel Cashman writes: > From: dcashman > > ASLR currently only uses 8 bits to generate the random offset for the > mmap base address on 32 bit architectures. This value was chosen to > prevent a poorly chosen value from dividing the address space in such > a way as to prevent large allocations.

[PATCH 1/2] mm: mmap: Add new /proc tunable for mmap_base ASLR.

2015-10-28 Thread Daniel Cashman
From: dcashman ASLR currently only uses 8 bits to generate the random offset for the mmap base address on 32 bit architectures. This value was chosen to prevent a poorly chosen value from dividing the address space in such a way as to prevent large allocations. This may not be an issue on all pla