Re: [PATCH 1/2] mfd: twl4030-audio: fix sibling-node lookup

2017-11-29 Thread Lee Jones
On Sat, 11 Nov 2017, Johan Hovold wrote: > A helper purported to look up a child node based on its name was using > the wrong of-helper and ended up prematurely freeing the parent of-node > while leaking any matching node. > > To make things worse, any matching node would not even necessarily be

Re: [PATCH 1/2] mfd: twl4030-audio: fix sibling-node lookup

2017-11-14 Thread Johan Hovold
On Mon, Nov 13, 2017 at 10:13:42PM +0200, Peter Ujfalusi wrote: > On 11/11/2017 05:38 PM, Johan Hovold wrote: > > A helper purported to look up a child node based on its name was using > > the wrong of-helper and ended up prematurely freeing the parent of-node > > while leaking any matching node. >

Re: [PATCH 1/2] mfd: twl4030-audio: fix sibling-node lookup

2017-11-13 Thread Peter Ujfalusi
On 11/11/2017 05:38 PM, Johan Hovold wrote: > A helper purported to look up a child node based on its name was using > the wrong of-helper and ended up prematurely freeing the parent of-node > while leaking any matching node. > > To make things worse, any matching node would not even necessarily b

Re: [PATCH 1/2] mfd: twl4030-audio: fix sibling-node lookup

2017-11-13 Thread Lee Jones
On Sat, 11 Nov 2017, Johan Hovold wrote: > A helper purported to look up a child node based on its name was using > the wrong of-helper and ended up prematurely freeing the parent of-node > while leaking any matching node. > > To make things worse, any matching node would not even necessarily be

[PATCH 1/2] mfd: twl4030-audio: fix sibling-node lookup

2017-11-11 Thread Johan Hovold
A helper purported to look up a child node based on its name was using the wrong of-helper and ended up prematurely freeing the parent of-node while leaking any matching node. To make things worse, any matching node would not even necessarily be a child node as the whole device tree was searched d