Re: [PATCH 1/2] leds: core: Introduce LED pattern trigger

2018-07-31 Thread Baolin Wang
Hi Jacek, On 31 July 2018 at 18:53, Jacek Anaszewski wrote: > Hi Baolin, > > Thank you for the patch set. I have one note regarding the way how > trigger specific sysfs attributes are created/removed, please refer > to my comment in the code below. > > On 07/30/2018 02:29 PM, Baolin Wang wrote: >

Re: [PATCH 1/2] leds: core: Introduce LED pattern trigger

2018-07-31 Thread Jacek Anaszewski
Hi Baolin, Thank you for the patch set. I have one note regarding the way how trigger specific sysfs attributes are created/removed, please refer to my comment in the code below. On 07/30/2018 02:29 PM, Baolin Wang wrote: > Some LED controllers have support for autonomously controlling > brightne

Re: [PATCH 1/2] leds: core: Introduce LED pattern trigger

2018-07-30 Thread Baolin Wang
On 31 July 2018 at 14:22, Baolin Wang wrote: > Hi Bjorn, > > On 31 July 2018 at 11:54, Bjorn Andersson wrote: >> On Mon 30 Jul 05:29 PDT 2018, Baolin Wang wrote: >> >>> Some LED controllers have support for autonomously controlling >>> brightness over time, according to some preprogrammed pattern

Re: [PATCH 1/2] leds: core: Introduce LED pattern trigger

2018-07-30 Thread Baolin Wang
Hi Bjorn, On 31 July 2018 at 11:54, Bjorn Andersson wrote: > On Mon 30 Jul 05:29 PDT 2018, Baolin Wang wrote: > >> Some LED controllers have support for autonomously controlling >> brightness over time, according to some preprogrammed pattern or >> function. >> >> This patch adds pattern trigger

Re: [PATCH 1/2] leds: core: Introduce LED pattern trigger

2018-07-30 Thread Bjorn Andersson
On Mon 30 Jul 05:29 PDT 2018, Baolin Wang wrote: > Some LED controllers have support for autonomously controlling > brightness over time, according to some preprogrammed pattern or > function. > > This patch adds pattern trigger that LED device can configure the > pattern and trigger it. > > Sig

[PATCH 1/2] leds: core: Introduce LED pattern trigger

2018-07-30 Thread Baolin Wang
Some LED controllers have support for autonomously controlling brightness over time, according to some preprogrammed pattern or function. This patch adds pattern trigger that LED device can configure the pattern and trigger it. Signed-off-by: Raphael Teysseyre Signed-off-by: Baolin Wang --- ..