Re: [PATCH 1/2] hwmon: (lm90) split set&show temp as common codes

2014-02-27 Thread Wei Ni
On 02/26/2014 12:06 AM, Guenter Roeck wrote: > On Tue, Feb 25, 2014 at 05:21:40PM +0800, Wei Ni wrote: >> On 02/25/2014 04:57 PM, Guenter Roeck wrote: >>> On 02/25/2014 12:21 AM, Wei Ni wrote: On 02/25/2014 02:32 PM, Guenter Roeck wrote: > On 02/24/2014 10:21 PM, Wei Ni wrote: >> Split

Re: [PATCH 1/2] hwmon: (lm90) split set&show temp as common codes

2014-02-25 Thread Guenter Roeck
On Tue, Feb 25, 2014 at 05:21:40PM +0800, Wei Ni wrote: > On 02/25/2014 04:57 PM, Guenter Roeck wrote: > > On 02/25/2014 12:21 AM, Wei Ni wrote: > >> On 02/25/2014 02:32 PM, Guenter Roeck wrote: > >>> On 02/24/2014 10:21 PM, Wei Ni wrote: > Split set&show temp codes as common functions, so we

Re: [PATCH 1/2] hwmon: (lm90) split set&show temp as common codes

2014-02-25 Thread Wei Ni
On 02/25/2014 04:57 PM, Guenter Roeck wrote: > On 02/25/2014 12:21 AM, Wei Ni wrote: >> On 02/25/2014 02:32 PM, Guenter Roeck wrote: >>> On 02/24/2014 10:21 PM, Wei Ni wrote: Split set&show temp codes as common functions, so we can use it directly when implement linux thermal framework. >

Re: [PATCH 1/2] hwmon: (lm90) split set&show temp as common codes

2014-02-25 Thread Guenter Roeck
On 02/25/2014 12:21 AM, Wei Ni wrote: On 02/25/2014 02:32 PM, Guenter Roeck wrote: On 02/24/2014 10:21 PM, Wei Ni wrote: Split set&show temp codes as common functions, so we can use it directly when implement linux thermal framework. And handle error return value for the lm90_select_remote_chan

Re: [PATCH 1/2] hwmon: (lm90) split set&show temp as common codes

2014-02-25 Thread Wei Ni
On 02/25/2014 02:32 PM, Guenter Roeck wrote: > On 02/24/2014 10:21 PM, Wei Ni wrote: >> Split set&show temp codes as common functions, so we can use it >> directly when implement linux thermal framework. >> And handle error return value for the lm90_select_remote_channel >> and write_tempx, then se

Re: [PATCH 1/2] hwmon: (lm90) split set&show temp as common codes

2014-02-24 Thread Guenter Roeck
On 02/24/2014 10:21 PM, Wei Ni wrote: Split set&show temp codes as common functions, so we can use it directly when implement linux thermal framework. And handle error return value for the lm90_select_remote_channel and write_tempx, then set_temp8 and set_temp11 could return it to user-space. Si

[PATCH 1/2] hwmon: (lm90) split set&show temp as common codes

2014-02-24 Thread Wei Ni
Split set&show temp codes as common functions, so we can use it directly when implement linux thermal framework. And handle error return value for the lm90_select_remote_channel and write_tempx, then set_temp8 and set_temp11 could return it to user-space. Signed-off-by: Wei Ni Signed-off-by: Jean