Re: [PATCH 1/2] genirq: Generic chip: add irq_unmap_generic_chip

Hi Thomas, On 09/02/2016 05:12 PM, Thomas Gleixner wrote: > On Mon, 1 Aug 2016, Sebastian Frias wrote: >> NOTE: While the proposed unmap() function attempts to undo as much things >> as done by the map() function, I did not find a way to undo the following: >> >> a) irq_gc_init_mask_cache(gc, dgc-

Re: [PATCH 1/2] genirq: Generic chip: add irq_unmap_generic_chip

On Mon, 1 Aug 2016, Sebastian Frias wrote: > NOTE: While the proposed unmap() function attempts to undo as much things > as done by the map() function, I did not find a way to undo the following: > > a) irq_gc_init_mask_cache(gc, dgc->gc_flags) You can't undo that. Because that represents the mas

Re: [PATCH 1/2] genirq: Generic chip: add irq_unmap_generic_chip

Hi, I don't know if somebody has had the time to look at these patches, but if you have comments (even if related to removing the "fixes" tag if you don't consider this a fix) please let me know. Best regards, Sebastian On 08/01/2016 04:27 PM, Sebastian Frias wrote: > Without this patch irq_dom

[PATCH 1/2] genirq: Generic chip: add irq_unmap_generic_chip

Without this patch irq_domain_disassociate() cannot properly release the interrupt. Indeed, irq_map_generic_chip() checks a bit on 'gc->installed' but said bit is never cleared, only set. Commit 088f40b7b027 ("genirq: Generic chip: Add linear irq domain support") added irq_map_generic_chip() funct