Re: [PATCH 1/2] fs: ext4: use BUG_ON if writepage call comes from direct reclaim

2018-07-04 Thread Michal Hocko
On Tue 03-07-18 10:05:04, Yang Shi wrote: > > > On 7/3/18 3:39 AM, Theodore Y. Ts'o wrote: > > On Tue, Jul 03, 2018 at 12:11:18PM +0800, Yang Shi wrote: > > > direct reclaim doesn't write out filesystem page, only kswapd could do > > > it. So, if the call comes from direct reclaim, it is definite

Re: [PATCH 1/2] fs: ext4: use BUG_ON if writepage call comes from direct reclaim

2018-07-03 Thread Theodore Y. Ts'o
On Tue, Jul 03, 2018 at 10:05:04AM -0700, Yang Shi wrote: > I'm not sure if it is a good choice to let filesystem handle such vital VM > regression. IMHO, writing out filesystem page from direct reclaim context is > a vital VM bug. It means something is definitely wrong in VM. It should > never hap

Re: [PATCH 1/2] fs: ext4: use BUG_ON if writepage call comes from direct reclaim

2018-07-03 Thread Yang Shi
On 7/3/18 10:05 AM, Yang Shi wrote: On 7/3/18 3:39 AM, Theodore Y. Ts'o wrote: On Tue, Jul 03, 2018 at 12:11:18PM +0800, Yang Shi wrote: direct reclaim doesn't write out filesystem page, only kswapd could do it. So, if the call comes from direct reclaim, it is definitely a bug. And, Mel G

Re: [PATCH 1/2] fs: ext4: use BUG_ON if writepage call comes from direct reclaim

2018-07-03 Thread Yang Shi
On 7/3/18 3:39 AM, Theodore Y. Ts'o wrote: On Tue, Jul 03, 2018 at 12:11:18PM +0800, Yang Shi wrote: direct reclaim doesn't write out filesystem page, only kswapd could do it. So, if the call comes from direct reclaim, it is definitely a bug. And, Mel Gormane also mentioned "Ultimately, this

Re: [PATCH 1/2] fs: ext4: use BUG_ON if writepage call comes from direct reclaim

2018-07-03 Thread Theodore Y. Ts'o
On Tue, Jul 03, 2018 at 12:11:18PM +0800, Yang Shi wrote: > direct reclaim doesn't write out filesystem page, only kswapd could do > it. So, if the call comes from direct reclaim, it is definitely a bug. > > And, Mel Gormane also mentioned "Ultimately, this will be a BUG_ON." In > commit 94054fa3f

[PATCH 1/2] fs: ext4: use BUG_ON if writepage call comes from direct reclaim

2018-07-02 Thread Yang Shi
direct reclaim doesn't write out filesystem page, only kswapd could do it. So, if the call comes from direct reclaim, it is definitely a bug. And, Mel Gormane also mentioned "Ultimately, this will be a BUG_ON." In commit 94054fa3fca1fd78db02cb3d68d5627120f0a1d4 ("xfs: warn if direct reclaim tries