Re: [PATCH 1/2] fs/efs/inode.c: follow style guide

2021-01-27 Thread Amy Parker
On Wed, Jan 27, 2021 at 9:08 AM Kari Argillander wrote: > > On Tue, Jan 26, 2021 at 12:58:05PM -0800, Amy Parker wrote: > > This patch updates inode.c for EFS to follow the kernel style guide. > > > +++ b/fs/efs/inode.c > > @@ -109,9 +109,9 @@ struct inode *efs_iget(struct super_block *super, > >

Re: [PATCH 1/2] fs/efs/inode.c: follow style guide

2021-01-27 Thread Kari Argillander
On Tue, Jan 26, 2021 at 12:58:05PM -0800, Amy Parker wrote: > This patch updates inode.c for EFS to follow the kernel style guide. > +++ b/fs/efs/inode.c > @@ -109,9 +109,9 @@ struct inode *efs_iget(struct super_block *super, > unsigned long ino) >/* this is the number of blocks in the fil

Re: [PATCH 1/2] fs/efs/inode.c: follow style guide

2021-01-26 Thread Randy Dunlap
On 1/26/21 9:13 PM, Amy Parker wrote: > On Tue, Jan 26, 2021 at 7:59 PM Randy Dunlap wrote: >> >> On 1/26/21 7:46 PM, Randy Dunlap wrote: >>> Hi Amy, >>> >>> What mail client did you use? >>> It is breaking (splitting) long lines into shorter lines and that >>> makes it not possible to apply the p

Re: [PATCH 1/2] fs/efs/inode.c: follow style guide

2021-01-26 Thread Amy Parker
On Tue, Jan 26, 2021 at 7:59 PM Randy Dunlap wrote: > > On 1/26/21 7:46 PM, Randy Dunlap wrote: > > Hi Amy, > > > > What mail client did you use? > > It is breaking (splitting) long lines into shorter lines and that > > makes it not possible to apply the patch cleanly. Was worried about that, tho

Re: [PATCH 1/2] fs/efs/inode.c: follow style guide

2021-01-26 Thread Randy Dunlap
On 1/26/21 7:46 PM, Randy Dunlap wrote: > Hi Amy, > > What mail client did you use? > It is breaking (splitting) long lines into shorter lines and that > makes it not possible to apply the patch cleanly. > > You can see this problem below or on the web in an email archive. > > Possibly Documenta

Re: [PATCH 1/2] fs/efs/inode.c: follow style guide

2021-01-26 Thread Randy Dunlap
Hi Amy, What mail client did you use? It is breaking (splitting) long lines into shorter lines and that makes it not possible to apply the patch cleanly. You can see this problem below or on the web in an email archive. Possibly Documentation/process/email-clients.rst can help you. On 1/26/21

[PATCH 1/2] fs/efs/inode.c: follow style guide

2021-01-26 Thread Amy Parker
This patch updates inode.c for EFS to follow the kernel style guide. Signed-off-by: Amy Parker --- fs/efs/inode.c | 64 +- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/fs/efs/inode.c b/fs/efs/inode.c index 89e73a6f0d36..4e81e7a15af