Re: [PATCH 1/2] fpga: dfl: add driver_override support

2020-11-08 Thread Xu Yilun
Hi Greg, We created a 'driver_override' api for dfl bus, and a driver for userspace I/O access for dfl devices. Some new comments inline. On Wed, Oct 21, 2020 at 03:25:32PM +0800, Xu Yilun wrote: > Hi Greg, > > On Tue, Oct 20, 2020 at 11:21:55AM +0200, Greg KH wrote: > > On Tue, Oct 20, 2020 at

Re: [PATCH 1/2] fpga: dfl: add driver_override support

2020-10-21 Thread Xu Yilun
Hi Greg, On Tue, Oct 20, 2020 at 11:21:55AM +0200, Greg KH wrote: > On Tue, Oct 20, 2020 at 04:57:23PM +0800, Xu Yilun wrote: > > On Tue, Oct 20, 2020 at 09:32:59AM +0200, Greg KH wrote: > > > On Tue, Oct 20, 2020 at 03:11:58PM +0800, Xu Yilun wrote: > > > > I think it is normal case that a driver

Re: [PATCH 1/2] fpga: dfl: add driver_override support

2020-10-20 Thread Tom Rix
On 10/20/20 12:11 AM, Xu Yilun wrote: > int __dfl_driver_register(struct dfl_driver *dfl_drv, struct module > *owner) > { > - if (!dfl_drv || !dfl_drv->probe || !dfl_drv->id_table) > + if (!dfl_drv || !dfl_drv->probe) id_table is still needed for the normal case.

Re: [PATCH 1/2] fpga: dfl: add driver_override support

2020-10-20 Thread Greg KH
On Tue, Oct 20, 2020 at 04:57:23PM +0800, Xu Yilun wrote: > On Tue, Oct 20, 2020 at 09:32:59AM +0200, Greg KH wrote: > > On Tue, Oct 20, 2020 at 03:11:58PM +0800, Xu Yilun wrote: > > > I think it is normal case that a driver is successfully registered but > > > doesn't match any device because it p

Re: [PATCH 1/2] fpga: dfl: add driver_override support

2020-10-20 Thread Xu Yilun
On Tue, Oct 20, 2020 at 09:32:59AM +0200, Greg KH wrote: > On Tue, Oct 20, 2020 at 03:11:58PM +0800, Xu Yilun wrote: > > I think it is normal case that a driver is successfully registered but > > doesn't match any device because it provides no id_table. > > How is that "normal"? What would ever c

Re: [PATCH 1/2] fpga: dfl: add driver_override support

2020-10-20 Thread Greg KH
On Tue, Oct 20, 2020 at 03:11:58PM +0800, Xu Yilun wrote: > I think it is normal case that a driver is successfully registered but > doesn't match any device because it provides no id_table. How is that "normal"? What would ever cause that driver to be bound to a device then? And you better not

Re: [PATCH 1/2] fpga: dfl: add driver_override support

2020-10-20 Thread Xu Yilun
> >>> int __dfl_driver_register(struct dfl_driver *dfl_drv, struct module > >>> *owner) > >>> { > >>> - if (!dfl_drv || !dfl_drv->probe || !dfl_drv->id_table) > >>> + if (!dfl_drv || !dfl_drv->probe) > >> id_table is still needed for the normal case. > >> > >> Instead of removing this check, cou

Re: [PATCH 1/2] fpga: dfl: add driver_override support

2020-10-19 Thread Xu Yilun
On Mon, Oct 19, 2020 at 11:03:16AM +0200, Greg KH wrote: > On Mon, Oct 19, 2020 at 04:52:33PM +0800, Xu Yilun wrote: > > On Mon, Oct 19, 2020 at 12:06:13PM +0800, Xu Yilun wrote: > > > On Fri, Oct 16, 2020 at 09:21:50AM -0700, Tom Rix wrote: > > > > > > > > On 10/15/20 11:02 PM, Xu Yilun wrote: >

Re: [PATCH 1/2] fpga: dfl: add driver_override support

2020-10-19 Thread Tom Rix
On 10/18/20 9:06 PM, Xu Yilun wrote: > On Fri, Oct 16, 2020 at 09:21:50AM -0700, Tom Rix wrote: >> On 10/15/20 11:02 PM, Xu Yilun wrote: >>> Add support for overriding the default matching of a dfl device to a dfl >>> driver. It follows the same way that can be used for PCI and platform >>> devic

Re: [PATCH 1/2] fpga: dfl: add driver_override support

2020-10-19 Thread Greg KH
On Mon, Oct 19, 2020 at 04:52:33PM +0800, Xu Yilun wrote: > On Mon, Oct 19, 2020 at 12:06:13PM +0800, Xu Yilun wrote: > > On Fri, Oct 16, 2020 at 09:21:50AM -0700, Tom Rix wrote: > > > > > > On 10/15/20 11:02 PM, Xu Yilun wrote: > > > > Add support for overriding the default matching of a dfl devi

Re: [PATCH 1/2] fpga: dfl: add driver_override support

2020-10-19 Thread Xu Yilun
On Mon, Oct 19, 2020 at 12:06:13PM +0800, Xu Yilun wrote: > On Fri, Oct 16, 2020 at 09:21:50AM -0700, Tom Rix wrote: > > > > On 10/15/20 11:02 PM, Xu Yilun wrote: > > > Add support for overriding the default matching of a dfl device to a dfl > > > driver. It follows the same way that can be used f

Re: [PATCH 1/2] fpga: dfl: add driver_override support

2020-10-19 Thread gre...@linuxfoundation.org
On Mon, Oct 19, 2020 at 03:50:32PM +0800, Xu Yilun wrote: > On Mon, Oct 19, 2020 at 03:46:23PM +0800, Wu, Hao wrote: > > > On Fri, Oct 16, 2020 at 09:21:50AM -0700, Tom Rix wrote: > > > > > > > > On 10/15/20 11:02 PM, Xu Yilun wrote: > > > > > Add support for overriding the default matching of a df

Re: [PATCH 1/2] fpga: dfl: add driver_override support

2020-10-19 Thread Xu Yilun
On Mon, Oct 19, 2020 at 03:46:23PM +0800, Wu, Hao wrote: > > On Fri, Oct 16, 2020 at 09:21:50AM -0700, Tom Rix wrote: > > > > > > On 10/15/20 11:02 PM, Xu Yilun wrote: > > > > Add support for overriding the default matching of a dfl device to a dfl > > > > driver. It follows the same way that can b

RE: [PATCH 1/2] fpga: dfl: add driver_override support

2020-10-19 Thread Wu, Hao
> On Fri, Oct 16, 2020 at 09:21:50AM -0700, Tom Rix wrote: > > > > On 10/15/20 11:02 PM, Xu Yilun wrote: > > > Add support for overriding the default matching of a dfl device to a dfl > > > driver. It follows the same way that can be used for PCI and platform > > > devices. This patch adds the 'dri

Re: [PATCH 1/2] fpga: dfl: add driver_override support

2020-10-18 Thread Xu Yilun
On Fri, Oct 16, 2020 at 09:21:50AM -0700, Tom Rix wrote: > > On 10/15/20 11:02 PM, Xu Yilun wrote: > > Add support for overriding the default matching of a dfl device to a dfl > > driver. It follows the same way that can be used for PCI and platform > > devices. This patch adds the 'driver_overrid

Re: [PATCH 1/2] fpga: dfl: add driver_override support

2020-10-16 Thread Tom Rix
On 10/15/20 11:02 PM, Xu Yilun wrote: > Add support for overriding the default matching of a dfl device to a dfl > driver. It follows the same way that can be used for PCI and platform > devices. This patch adds the 'driver_override' sysfs file. > > Signed-off-by: Xu Yilun > --- > Documentation

[PATCH 1/2] fpga: dfl: add driver_override support

2020-10-15 Thread Xu Yilun
Add support for overriding the default matching of a dfl device to a dfl driver. It follows the same way that can be used for PCI and platform devices. This patch adds the 'driver_override' sysfs file. Signed-off-by: Xu Yilun --- Documentation/ABI/testing/sysfs-bus-dfl | 28 ++--- dr