Re: [PATCH 1/2] external interrupts: abstraction layer

2005-08-24 Thread Brent Casavant
On Wed, 24 Aug 2005, Christoph Hellwig wrote: > Sorry, the whole behaviour is complety fine. I just don't thing the name > and calling convention of file_to_extint_device is optimal. It should > take an struct inode * and be called just to_extint_device or someting. > The above would become > >

Re: [PATCH 1/2] external interrupts: abstraction layer

2005-08-24 Thread Christoph Hellwig
> > > +static int extint_counter_open(struct inode *inode, struct file *filp) > > > +{ > > > + struct extint_device *ed = file_to_extint_device(filp); > > > > you don't need the file but just the inode (strictly speaking the cdev), > > and doing this based on the file is rather confusing to the re

Re: [PATCH 1/2] external interrupts: abstraction layer

2005-08-23 Thread Brent Casavant
On Sat, 20 Aug 2005, Christoph Hellwig wrote: > > +static struct page *extint_counter_vma_nopage(struct vm_area_struct *vma, > > + unsigned long address, int *type) > > +{ > > + struct extint_device *ed = vma->vm_private_data; > > + struct page *page; >

Re: [PATCH 1/2] external interrupts: abstraction layer

2005-08-20 Thread Christoph Hellwig
> diff --git a/drivers/char/extint.c b/drivers/char/extint.c > new file mode 100644 > --- /dev/null > +++ b/drivers/char/extint.c > @@ -0,0 +1,673 @@ > +/* > + * This file is subject to the terms and conditions of the GNU General Public > + * License. See the file "COPYING" in the main directory o

[PATCH 1/2] external interrupts: abstraction layer

2005-08-19 Thread Brent Casavant
This patch implements an abstraction layer for external interrupt devices. It creates a new sysfs class "extint" which provides a number of read-write and a few read-only attributes which can be used to control a lower-level hardware-specific external interrupt device driver. The abstraction layer

[PATCH 1/2] external interrupts: abstraction layer

2005-07-28 Thread Brent Casavant
This patch implements an abstraction layer for external interrupt devices. It creates a new sysfs class "extint" which provides a number of read-write and a few read-only attributes which can be used to control a lower-level hardware-specific external interrupt device driver. The abstraction layer