On Thu, 2012-11-15 at 20:05 +0530, viresh kumar wrote:
> On Thu, Nov 15, 2012 at 7:50 PM, Andy Shevchenko
> wrote:
> > diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
>
> > +static inline bool is_slave_direction(enum dma_transfer_direction
> > direction)
> > +{
> > + return (di
On Thu, 2012-11-15 at 20:28 +0530, viresh kumar wrote:
> On Thu, Nov 15, 2012 at 8:05 PM, viresh kumar wrote:
> > On Thu, Nov 15, 2012 at 7:50 PM, Andy Shevchenko
> > wrote:
> >> diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
> >
> >> +static inline bool is_slave_direction(enum dma_t
On Thu, Nov 15, 2012 at 8:05 PM, viresh kumar wrote:
> On Thu, Nov 15, 2012 at 7:50 PM, Andy Shevchenko
> wrote:
>> diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
>
>> +static inline bool is_slave_direction(enum dma_transfer_direction direction)
>> +{
>> + return (direction == D
On Thu, Nov 15, 2012 at 7:50 PM, Andy Shevchenko
wrote:
> diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
> +static inline bool is_slave_direction(enum dma_transfer_direction direction)
> +{
> + return (direction == DMA_MEM_TO_DEV) || (direction == DMA_DEV_TO_MEM);
> +}
I would
dma_transfer_direction is a normal enum. It means we can't usually use the
values as bit fields. Let's adjust this check and move it above the usage of
the direction parameter.
This patch introduces helper function is_slave_direction() that will be used
later in other places of the code.
Signed-o
5 matches
Mail list logo
