Re: [PATCH 1/2] dt-bindings: nand: meson: add Amlogic NAND controller driver

2018-06-27 Thread Kevin Hilman
Rob Herring writes: > On Sun, Jun 24, 2018 at 12:46:59AM +0200, Martin Blumenstingl wrote: >> Hello Yixun, Hello Liang, >> >> I have a few small comments inline below >> additionally I tried to explain the reason behind >> "amlogic,mmc-syscon", clkin0 and clkin1 so Rob (or the devicetree >> main

Re: [PATCH 1/2] dt-bindings: nand: meson: add Amlogic NAND controller driver

2018-06-26 Thread Rob Herring
On Sun, Jun 24, 2018 at 12:46:59AM +0200, Martin Blumenstingl wrote: > Hello Yixun, Hello Liang, > > I have a few small comments inline below > additionally I tried to explain the reason behind > "amlogic,mmc-syscon", clkin0 and clkin1 so Rob (or the devicetree > maintainers in general) can give f

Re: [PATCH 1/2] dt-bindings: nand: meson: add Amlogic NAND controller driver

2018-06-24 Thread Boris Brezillon
Hi Yixun, On Wed, 13 Jun 2018 16:13:13 + Yixun Lan wrote: > From: Liang Yang > > Add Amlogic NAND controller dt-bindings for Meson SoC, > Current this driver support GXBB/GXL/AXG platform. > > Signed-off-by: Liang Yang > Signed-off-by: Yixun Lan > --- > .../bindings/mtd/amlogic,meson-n

Re: [PATCH 1/2] dt-bindings: nand: meson: add Amlogic NAND controller driver

2018-06-23 Thread Martin Blumenstingl
Hello Yixun, Hello Liang, I have a few small comments inline below additionally I tried to explain the reason behind "amlogic,mmc-syscon", clkin0 and clkin1 so Rob (or the devicetree maintainers in general) can give feedback. feel free to correct me wherever I'm wrong or provide additional notes i

[PATCH 1/2] dt-bindings: nand: meson: add Amlogic NAND controller driver

2018-06-13 Thread Yixun Lan
From: Liang Yang Add Amlogic NAND controller dt-bindings for Meson SoC, Current this driver support GXBB/GXL/AXG platform. Signed-off-by: Liang Yang Signed-off-by: Yixun Lan --- .../bindings/mtd/amlogic,meson-nand.txt | 118 ++ 1 file changed, 118 insertions(+) create m