Re: [PATCH 1/2] drm/rockchip: vop use is_enabled instead of dpms mode

2015-01-22 Thread Daniel Vetter
On Thu, Jan 22, 2015 at 04:56:09PM +0800, Mark yao wrote: > On 2015年01月22日 15:33, Daniel Vetter wrote: > >On Thu, Jan 22, 2015 at 03:05:32PM +0800, Mark Yao wrote: > >>drm dpms have many power modes: ON,OFF,SUSPEND,STANDBY, etc. > >>but vop only have enable/disable mode, maybe case such bug: > >>

Re: [PATCH 1/2] drm/rockchip: vop use is_enabled instead of dpms mode

2015-01-22 Thread Mark yao
On 2015年01月22日 15:33, Daniel Vetter wrote: On Thu, Jan 22, 2015 at 03:05:32PM +0800, Mark Yao wrote: drm dpms have many power modes: ON,OFF,SUSPEND,STANDBY, etc. but vop only have enable/disable mode, maybe case such bug: --> DRM_DPMS_ON: power on vop --> DRM_DPMS_SUSPEND: power off vop --

Re: [PATCH 1/2] drm/rockchip: vop use is_enabled instead of dpms mode

2015-01-21 Thread Daniel Vetter
On Thu, Jan 22, 2015 at 03:05:32PM +0800, Mark Yao wrote: > drm dpms have many power modes: ON,OFF,SUSPEND,STANDBY, etc. > but vop only have enable/disable mode, maybe case such bug: > --> DRM_DPMS_ON: power on vop > --> DRM_DPMS_SUSPEND: power off vop > --> DRM_DPMS_OFF: already power off at SU

[PATCH 1/2] drm/rockchip: vop use is_enabled instead of dpms mode

2015-01-21 Thread Mark Yao
drm dpms have many power modes: ON,OFF,SUSPEND,STANDBY, etc. but vop only have enable/disable mode, maybe case such bug: --> DRM_DPMS_ON: power on vop --> DRM_DPMS_SUSPEND: power off vop --> DRM_DPMS_OFF: already power off at SUSPEND, crash so use a bool val is more suitable. Signed-off-by: Mar