Re: [PATCH 1/2] driver: regmap: add regmap_parse_val api

2014-03-06 Thread Mark Brown
On Wed, Feb 19, 2014 at 06:44:13PM +0800, Nenghua Cao wrote: > From: Nenghua Cao > > In some cases, we need regmap's format parse_val function > to do be/le translation according to the bus configuration. > For example, snd_soc_bytes_put() uses regmap to write/read values, > and use cpu_to_be

Re: [PATCH 1/2] driver: regmap: add regmap_parse_val api

2014-03-04 Thread Mark Brown
On Mon, Mar 03, 2014 at 06:44:21PM +0800, Nenghua Cao wrote: > Do you have any comments about these two patches? Thanks! I've not looked at it yet, please don't nag - one of the reasons it got bumped down my priority list is that you nagged previously. I tend to do this partly as a functio

Re: [PATCH 1/2] driver: regmap: add regmap_parse_val api

2014-03-03 Thread Nenghua Cao
On 02/20/2014 09:42 PM, Mark Brown wrote: > On Thu, Feb 20, 2014 at 08:09:51PM +0800, Nenghua Cao wrote: > >> My intention is not chasing you. I am just afraid if there is any >> other mistake when submitting this patch to open source. Please do what >> you want to do. Thanks! > > It's certa

Re: [PATCH 1/2] driver: regmap: add regmap_parse_val api

2014-02-20 Thread Mark Brown
On Thu, Feb 20, 2014 at 08:09:51PM +0800, Nenghua Cao wrote: > My intention is not chasing you. I am just afraid if there is any > other mistake when submitting this patch to open source. Please do what > you want to do. Thanks! It's certainly fine in terms of submission, no problems there!

Re: [PATCH 1/2] driver: regmap: add regmap_parse_val api

2014-02-20 Thread Nenghua Cao
On 02/20/2014 04:55 PM, Mark Brown wrote: > On Thu, Feb 20, 2014 at 04:24:06PM +0800, Nenghua Cao wrote: > >> Do you still have any other problem which have impact on evaluating >> these two patches? > > You're chasing me for a reply after a day - that's way too soon, please > allow a reason

Re: [PATCH 1/2] driver: regmap: add regmap_parse_val api

2014-02-20 Thread Mark Brown
On Thu, Feb 20, 2014 at 04:24:06PM +0800, Nenghua Cao wrote: > Do you still have any other problem which have impact on evaluating > these two patches? You're chasing me for a reply after a day - that's way too soon, please allow a reasonable time for a response. A week or so is usually a g

Re: [PATCH 1/2] driver: regmap: add regmap_parse_val api

2014-02-20 Thread Nenghua Cao
Hi, Mark: Do you still have any other problem which have impact on evaluating these two patches? BR Nenghua On 02/19/2014 06:44 PM, Nenghua Cao wrote: > From: Nenghua Cao > > In some cases, we need regmap's format parse_val function > to do be/le translation according to the bus confi

Re: [PATCH 1/2] driver: regmap: add regmap_parse_val api

2014-02-19 Thread Nenghua Cao
On 02/19/2014 03:50 PM, Mark Brown wrote: > On Wed, Feb 19, 2014 at 01:28:43PM +0800, Nenghua Cao wrote: >>Update Liam and Mark's mail. > > I can't do anything useful with patches that are quoted, sorry. None of > the tools know how to strip out quotes. > Hi ,Mark Sorry for giving

[PATCH 1/2] driver: regmap: add regmap_parse_val api

2014-02-19 Thread Nenghua Cao
From: Nenghua Cao In some cases, we need regmap's format parse_val function to do be/le translation according to the bus configuration. For example, snd_soc_bytes_put() uses regmap to write/read values, and use cpu_to_be() directly to covert MASK into big endian. This is a defect, and should

Re: [PATCH 1/2] driver: regmap: add regmap_parse_val api

2014-02-18 Thread Mark Brown
On Wed, Feb 19, 2014 at 01:28:43PM +0800, Nenghua Cao wrote: >Update Liam and Mark's mail. I can't do anything useful with patches that are quoted, sorry. None of the tools know how to strip out quotes. signature.asc Description: Digital signature

Re: [PATCH 1/2] driver: regmap: add regmap_parse_val api

2014-02-18 Thread Nenghua Cao
Update Liam and Mark's mail. On 02/19/2014 01:19 PM, Nenghua Cao wrote: > From: Nenghua Cao > > In some cases, we need regmap's format parse_val function > to do be/le translation according to the bus configuration. > For example, snd_soc_bytes_put() uses regmap to write/read values, > an

[PATCH 1/2] driver: regmap: add regmap_parse_val api

2014-02-18 Thread Nenghua Cao
From: Nenghua Cao In some cases, we need regmap's format parse_val function to do be/le translation according to the bus configuration. For example, snd_soc_bytes_put() uses regmap to write/read values, and use cpu_to_be() directly to covert MASK into big endian. This is a defect, and should