Re: [PATCH 1/2] don't wait on disk to start on resume

2013-02-04 Thread Aaron Lu
On 02/04/2013 08:07 AM, dbasehore . wrote: On the topic that we do a fast return for both scsi and ata. Now I don't remember everything about this (and correct me if I'm wrong) since I figured this out a few months ago. There are some dependencies that scsi has on the resume path of ata. I think

Re: [PATCH 1/2] don't wait on disk to start on resume

2013-02-04 Thread Aaron Lu
On 02/03/2013 02:23 PM, Aaron Lu wrote: > No, the modification is actually for disk. > With v8 of block layer runtime PM, it is no longer the case runtime > suspend is the same as system suspend for hard disk that utilize block > layer runtime PM: we quiesce the device and run its suspend callback

Re: [PATCH 1/2] don't wait on disk to start on resume

2013-02-03 Thread dbasehore .
On the topic that we do a fast return for both scsi and ata. Now I don't remember everything about this (and correct me if I'm wrong) since I figured this out a few months ago. There are some dependencies that scsi has on the resume path of ata. I think it's that before we can send the command to

Re: [PATCH 1/2] don't wait on disk to start on resume

2013-02-02 Thread Aaron Lu
On 02/02/2013 11:09 PM, Alan Stern wrote: > On Sat, 2 Feb 2013, Aaron Lu wrote: > An alternative way of possibly solving this problem from PM's point of view might be: 1 Set both ata port and scsi device's runtime status to RPM_SUSPENDED in their system suspend callback; > >

Re: [PATCH 1/2] don't wait on disk to start on resume

2013-02-02 Thread Alan Stern
On Sat, 2 Feb 2013, Aaron Lu wrote: > >> An alternative way of possibly solving this problem from PM's point of > >> view might be: > >> 1 Set both ata port and scsi device's runtime status to RPM_SUSPENDED > >> in their system suspend callback; By the way, what reason is there for doing this t

Re: [PATCH 1/2] don't wait on disk to start on resume

2013-02-02 Thread Aaron Lu
On 02/01/2013 11:28 PM, Alan Stern wrote: > On Fri, 1 Feb 2013, Aaron Lu wrote: > >> Hi Derek, >> >> On 12/21/2012 12:35 PM, Derek Basehore wrote: >>> We no longer wait for the disk to spin up in sd_resume. It now enters the >>> request to spinup the disk into the elevator and returns. >>> >>> A f

Re: [PATCH 1/2] don't wait on disk to start on resume

2013-02-01 Thread Alan Stern
On Fri, 1 Feb 2013, Aaron Lu wrote: > Hi Derek, > > On 12/21/2012 12:35 PM, Derek Basehore wrote: > > We no longer wait for the disk to spin up in sd_resume. It now enters the > > request to spinup the disk into the elevator and returns. > > > > A function is scheduled under the scsi_sd_probe_do

Re: [PATCH 1/2] don't wait on disk to start on resume

2013-02-01 Thread Aaron Lu
Hi Derek, On 12/21/2012 12:35 PM, Derek Basehore wrote: > We no longer wait for the disk to spin up in sd_resume. It now enters the > request to spinup the disk into the elevator and returns. > > A function is scheduled under the scsi_sd_probe_domain to wait for the command > to spinup the disk t

Re: [PATCH 1/2] don't wait on disk to start on resume

2013-01-31 Thread dbasehore .
That was a response to Sergei's message (which is properly tracked on the lists). On Thu, Jan 31, 2013 at 2:27 PM, James Bottomley wrote: > On Thu, 2013-01-31 at 14:00 -0800, dbasehore . wrote: >> (Resending as plain text so the message is tracked on vger) >> >> Hi, thanks for reading through my

Re: [PATCH 1/2] don't wait on disk to start on resume

2013-01-31 Thread James Bottomley
On Thu, 2013-01-31 at 14:00 -0800, dbasehore . wrote: > (Resending as plain text so the message is tracked on vger) > > Hi, thanks for reading through my patch. > > With regards to SCSI_SENSE_BUFFERSIZE, I'm following the precedent of > scsi_execute_req found in drivers/scsi/scsi_lib.c I have no

Re: [PATCH 1/2] don't wait on disk to start on resume

2013-01-31 Thread James Bottomley
On Thu, 2013-01-31 at 14:02 -0800, dbasehore . wrote: > (Resending message as plain text so it's tracked through vger lists) Just FYI ... I don't get messages sent to me personally and the list, so if it wasn't on vger, I haven't seen it. > I didn't notice the other call to async_synchronize_full

Re: [PATCH 1/2] don't wait on disk to start on resume

2013-01-31 Thread dbasehore .
(Resending message as plain text so it's tracked through vger lists) I didn't notice the other call to async_synchronize_full, I'll remove that one. I split up the functionality of sd_start_stop_device to ensure that the command to start the disk was sent before resume was completed. For now, it'

Re: [PATCH 1/2] don't wait on disk to start on resume

2013-01-31 Thread dbasehore .
(Resending as plain text so the message is tracked on vger) Hi, thanks for reading through my patch. With regards to SCSI_SENSE_BUFFERSIZE, I'm following the precedent of scsi_execute_req found in drivers/scsi/scsi_lib.c It seems that it is used by the scsi_normalize_sense function which I call

Re: [PATCH 1/2] don't wait on disk to start on resume

2012-12-23 Thread James Bottomley
Missing cc to linux-scsi added On Thu, 2012-12-20 at 20:35 -0800, Derek Basehore wrote: > We no longer wait for the disk to spin up in sd_resume. It now enters the > request to spinup the disk into the elevator and returns. > > A function is scheduled under the scsi_sd_probe_domain to wait for t

Re: [PATCH 1/2] don't wait on disk to start on resume

2012-12-22 Thread Sergei Shtylyov
Hello. On 21-12-2012 8:35, Derek Basehore wrote: We no longer wait for the disk to spin up in sd_resume. It now enters the request to spinup the disk into the elevator and returns. A function is scheduled under the scsi_sd_probe_domain to wait for the command to spinup the disk to complete. Th

[PATCH 1/2] don't wait on disk to start on resume

2012-12-20 Thread Derek Basehore
We no longer wait for the disk to spin up in sd_resume. It now enters the request to spinup the disk into the elevator and returns. A function is scheduled under the scsi_sd_probe_domain to wait for the command to spinup the disk to complete. This function then checks for errors and cleans up afte