Re: [PATCH 1/2] cpustat: use accessor functions for get/set/add

2013-02-22 Thread Kevin Hilman
Viresh Kumar writes: > On Fri, Feb 22, 2013 at 11:26 AM, Kevin Hilman wrote: >> Add some accessor functions in order to facilitate the conversion to >> atomic reads/writes of cpustat values. >> >> Signed-off-by: Kevin Hilman >> --- >> drivers/cpufreq/cpufreq_governor.c | 18 - >

Re: [PATCH 1/2] cpustat: use accessor functions for get/set/add

2013-02-22 Thread Frederic Weisbecker
On Fri, Feb 22, 2013 at 02:58:51PM +0100, Peter Zijlstra wrote: > On Fri, 2013-02-22 at 14:38 +0100, Frederic Weisbecker wrote: > > Looks good, just a minor neat: > > > > On Thu, Feb 21, 2013 at 09:56:43PM -0800, Kevin Hilman wrote: > > > diff --git a/include/linux/kernel_stat.h b/include/linux/ke

Re: [PATCH 1/2] cpustat: use accessor functions for get/set/add

2013-02-22 Thread Peter Zijlstra
On Fri, 2013-02-22 at 14:38 +0100, Frederic Weisbecker wrote: > Looks good, just a minor neat: > > On Thu, Feb 21, 2013 at 09:56:43PM -0800, Kevin Hilman wrote: > > diff --git a/include/linux/kernel_stat.h b/include/linux/kernel_stat.h > > index 66b7078..df8ad75 100644 > > --- a/include/linux/kern

Re: [PATCH 1/2] cpustat: use accessor functions for get/set/add

2013-02-22 Thread Frederic Weisbecker
Looks good, just a minor neat: On Thu, Feb 21, 2013 at 09:56:43PM -0800, Kevin Hilman wrote: > diff --git a/include/linux/kernel_stat.h b/include/linux/kernel_stat.h > index 66b7078..df8ad75 100644 > --- a/include/linux/kernel_stat.h > +++ b/include/linux/kernel_stat.h > @@ -32,7 +32,7 @@ enum cpu

Re: [PATCH 1/2] cpustat: use accessor functions for get/set/add

2013-02-22 Thread Frederic Weisbecker
On Fri, Feb 22, 2013 at 12:47:33PM +0530, Amit Kucheria wrote: > On Fri, Feb 22, 2013 at 11:51 AM, Viresh Kumar > wrote: > > On Fri, Feb 22, 2013 at 11:26 AM, Kevin Hilman wrote: > >> Add some accessor functions in order to facilitate the conversion to > >> atomic reads/writes of cpustat values.

Re: [PATCH 1/2] cpustat: use accessor functions for get/set/add

2013-02-21 Thread Viresh Kumar
On 22 February 2013 12:47, Amit Kucheria wrote: > On Fri, Feb 22, 2013 at 11:51 AM, Viresh Kumar > wrote: >> BTW, i don't see kcpustat_cpu() used in >> >> kernel/sched/core.c| 12 +--- >> kernel/sched/cputime.c | 29 +-- >> >> I searche

Re: [PATCH 1/2] cpustat: use accessor functions for get/set/add

2013-02-21 Thread Amit Kucheria
On Fri, Feb 22, 2013 at 11:51 AM, Viresh Kumar wrote: > On Fri, Feb 22, 2013 at 11:26 AM, Kevin Hilman wrote: >> Add some accessor functions in order to facilitate the conversion to >> atomic reads/writes of cpustat values. >> >> Signed-off-by: Kevin Hilman >> --- >> drivers/cpufreq/cpufreq_gov

Re: [PATCH 1/2] cpustat: use accessor functions for get/set/add

2013-02-21 Thread Viresh Kumar
On Fri, Feb 22, 2013 at 11:26 AM, Kevin Hilman wrote: > Add some accessor functions in order to facilitate the conversion to > atomic reads/writes of cpustat values. > > Signed-off-by: Kevin Hilman > --- > drivers/cpufreq/cpufreq_governor.c | 18 - > drivers/cpufreq/cpufreq_ondem

[PATCH 1/2] cpustat: use accessor functions for get/set/add

2013-02-21 Thread Kevin Hilman
Add some accessor functions in order to facilitate the conversion to atomic reads/writes of cpustat values. Signed-off-by: Kevin Hilman --- arch/s390/appldata/appldata_os.c | 16 +++ drivers/cpufreq/cpufreq_governor.c | 18 - drivers/cpufreq/cpufreq_ondemand.c | 2