Re: [PATCH 1/2] bridge: multicast: add sanity check for general query destination

2014-03-10 Thread Cong Wang
On Sun, Mar 9, 2014 at 8:39 PM, Linus Lüssing wrote: > + is_general_query = group && ipv6_addr_any(group) ? true : false; > + Just "is_general_query = group && ipv6_addr_any(group);" should be okay. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

[PATCH 1/2] bridge: multicast: add sanity check for general query destination

2014-03-09 Thread Linus Lüssing
General IGMP and MLD queries are supposed to have the multicast link-local all-nodes address as their destination according to RFC2236 section 9, RFC3376 section 4.1.12/9.1, RFC2710 section 8 and RFC3810 section 5.1.15. Without this check, such malformed IGMP/MLD queries can result in a denial of